Make global metrics configurable#219
Merged
Merged
Conversation
Make the fulcio and timestamp logging metrics optional. These logging metrics have universal names and can be filtered and aggregated by any cluster or region, so they don't need to be recreated by another instance of the monitoring module. TUF is also only deployed once, so do not configure a second monitoring instance for it. Signed-off-by: Colleen Murphy <colleenmurphy@google.com>
cmurphy
force-pushed
the
logging-metrics-optional
branch
from
85ea314 to
198ff65
Compare
Member
|
Would it make sense to rework monitoring to only instantiate once without this explicit config? If I understand this, it seems like we might end up with config on one cluster affecting the other? |
Contributor
Author
It would make sense, this was just a lot easier.
We're already in a bit of a situation where one regional configuration owns some global resources, like TUF. It's a bit organizationally confusing but I don't see a risk of one config breaking the other region. |
loosebazooka
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the fulcio and timestamp logging metrics optional. These logging metrics have universal names and can be filtered and aggregated by any cluster or region, so they don't need to be recreated by another instance of the monitoring module.
TUF is also only deployed once, so do not configure a second monitoring instance for it.
Relates to https://github.com/sigstore/public-good-instance/issues/3603
Summary
Release Note
Documentation