fix(cli): inject pnpm.onlyBuiltDependencies to fix Vite template initialization crash#10686
Closed
Dharya-dev wants to merge 1 commit into
Closed
fix(cli): inject pnpm.onlyBuiltDependencies to fix Vite template initialization crash#10686Dharya-dev wants to merge 1 commit into
Dharya-dev wants to merge 1 commit into
Conversation
Contributor
|
@Dharya-dev is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Can you sign the commits please? See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits. Thank you. |
Author
|
Closing in favor of #10687 which contains verified commit signatures required by this repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10658.
Description
When running shadcn init with the Vite template using modern pnpm, the initialization process fails during pnpm install with [ERR_PNPM_IGNORED_BUILDS]. This happens because esbuild requires a post-install build script, which pnpm blocks by default for security.
Solution
This PR moves the package.json setup in create-template.ts to execute before pnpm install. It then automatically detects if the package manager is pnpm and injects "pnpm: { onlyBuiltDependencies: [esbuild] } into the package.json.
This signals to pnpm that the esbuild script is trusted, allowing the installation to succeed seamlessly out of the box without requiring manual .npmrc or pnpm-workspace.yaml overrides from the user.