feat(components): add ColorPicker component#10685
Draft
aviralj02 wants to merge 2 commits into
Draft
Conversation
Contributor
|
@aviralj02 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Can you sign the commits please? See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
ColorPickercomponent built on top ofreact-color-strip— a lightweight, accessible color strip primitive I authored andmaintain. I thought it might be a good fit for shadcn since there isn't a first-party color picker in the registry yet.
Happy to adjust anything that doesn't match the project's conventions — this is my first contribution here and I may have missed something.
What's included
registry/new-york-v4/ui/color-picker.tsx) — a hue strip with an optional shade strip (showShadeprop), supports controlled and uncontrolled usage, auto-sizes viaResizeObserverso it works in any container width_registry.tsfor both the UI component and the example, withreact-color-striplisted as a dependency so the CLI installs it automaticallyregistry/__index__.tsx,registry/bases/__index__.tsx(both radix and base sections), andexamples/__index__.tsxfor live previewstyles/radix-nova/ui/andstyles/base-nova/ui/for the live docs preview rendererexamples/radix/color-picker.tsxandexamples/base/color-picker.tsxshowing controlled usage with a live color swatchbaseandradixstyles, added tometa.jsonbetweencollapsibleandcomboboxreact-color-strip@^2.0.1added toapps/v4/package.jsonProps
valuestringdefaultValuestring"#ef4444"onChange(value: string) => voidonChangeComplete(value: string) => voidshowShadebooleanfalsedisabledbooleanfalseclassNamestringTest plan
npx shadcn@latest add color-pickerinstalls the component andreact-color-stripin a fresh Next.js projectshowShaderenders the shade strip and its drag updates the full hex valuevalue+onChange) and uncontrolled usage (defaultValueonly) both workdisabledprop prevents interaction on both strips/docs/components/color-pickerfor both radix and base styles