Skip to content

fix: forward base-mira tabs orientation#10679

Open
raashish1601 wants to merge 1 commit into
shadcn-ui:mainfrom
raashish1601:codex/10592-forward-tabs-orientation
Open

fix: forward base-mira tabs orientation#10679
raashish1601 wants to merge 1 commit into
shadcn-ui:mainfrom
raashish1601:codex/10592-forward-tabs-orientation

Conversation

@raashish1601
Copy link
Copy Markdown

Summary

  • forward the orientation prop to TabsPrimitive.Root in the base-mira tabs wrapper
  • update the generated base-mira tabs registry JSON so installed components receive the same fix

Closes #10592.

Validation

  • node -e "JSON.parse(require('fs').readFileSync('apps/v4/public/r/styles/base-mira/tabs.json','utf8')); console.log('json ok')"
  • corepack pnpm exec prettier --check apps/v4/styles/base-mira/ui/tabs.tsx apps/v4/public/r/styles/base-mira/tabs.json
  • corepack pnpm --filter=v4 exec eslint styles/base-mira/ui/tabs.tsx
  • corepack pnpm --filter=v4 exec tsc --noEmit --pretty false
  • git diff --cached --check

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 17, 2026

@raashish1601 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: base-mira Tabs wrapper does not forward orientation prop to TabsPrimitive.Root

1 participant