Skip to content

fix: support vertical carousel arrow keys#10669

Open
codejupiter wants to merge 1 commit into
shadcn-ui:mainfrom
codejupiter:codex/carousel-vertical-keys
Open

fix: support vertical carousel arrow keys#10669
codejupiter wants to merge 1 commit into
shadcn-ui:mainfrom
codejupiter:codex/carousel-vertical-keys

Conversation

@codejupiter
Copy link
Copy Markdown

Summary

  • Updates Base UI and Radix carousel keyboard handling so vertical carousels respond to ArrowUp / ArrowDown.
  • Keeps horizontal carousel behavior on ArrowLeft / ArrowRight.
  • Regenerates the v4 style registry outputs.

Why

Vertical carousels should use directional keys that match their axis. Before this change, the handler only listened for left/right keys regardless of orientation, so orientation="vertical" carousels ignored the natural up/down keyboard controls.

Fixes #10219.

Validation

  • npx -y pnpm@9.0.6 --filter=shadcn build
  • npx -y bun@latest run ./scripts/build-registry.mts from apps/v4
  • npx -y pnpm@9.0.6 --filter=v4 validate:registries
  • npx -y pnpm@9.0.6 --filter=v4 typecheck
  • npx -y pnpm@9.0.6 --filter=v4 lint
  • npx -y pnpm@9.0.6 --filter=v4 format:check
  • git diff --check

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 16, 2026

@codejupiter is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: Carousel ignores ArrowUp/ArrowDown keys when orientation is vertical

1 participant