Skip to content

fix: forward tabs orientation prop#10667

Open
codejupiter wants to merge 1 commit into
shadcn-ui:mainfrom
codejupiter:fix/tabs-orientation-forwarding
Open

fix: forward tabs orientation prop#10667
codejupiter wants to merge 1 commit into
shadcn-ui:mainfrom
codejupiter:fix/tabs-orientation-forwarding

Conversation

@codejupiter
Copy link
Copy Markdown

Summary

Forward the orientation prop from registry Tabs wrappers to the underlying Tabs root primitive.

Why

Several registry tab wrappers destructure orientation and use it for styling via data-orientation, but do not pass it through to the primitive. That means vertical tabs can render with vertical styling while the underlying primitive still behaves as horizontal for keyboard navigation and ARIA semantics.

This addresses the issue reported in #10592 and applies the same fix across the matching registry Tabs wrappers so the generated styles stay consistent.

Changes

  • Pass orientation={orientation} to Base UI and Radix Tabs root wrappers.
  • Update the generated registry JSON for affected tab style entries.
  • Preserve the existing default of "horizontal".

Validation

  • npx pnpm@9.0.6 install --frozen-lockfile
  • npx pnpm@9.0.6 --filter=shadcn build
  • npx pnpm@9.0.6 --filter=v4 typecheck
  • npx pnpm@9.0.6 --filter=v4 validate:registries
  • npx pnpm@9.0.6 --filter=v4 lint
  • npx pnpm@9.0.6 --filter=v4 format:check
  • git diff --check

Fixes #10592.

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 16, 2026

@codejupiter is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

Can you sign the commits please? See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: base-mira Tabs wrapper does not forward orientation prop to TabsPrimitive.Root

1 participant