fix: forward tabs orientation prop#10667
Open
codejupiter wants to merge 1 commit into
Open
Conversation
Contributor
|
@codejupiter is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Can you sign the commits please? See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward the
orientationprop from registryTabswrappers to the underlying Tabs root primitive.Why
Several registry tab wrappers destructure
orientationand use it for styling viadata-orientation, but do not pass it through to the primitive. That means vertical tabs can render with vertical styling while the underlying primitive still behaves as horizontal for keyboard navigation and ARIA semantics.This addresses the issue reported in #10592 and applies the same fix across the matching registry Tabs wrappers so the generated styles stay consistent.
Changes
orientation={orientation}to Base UI and Radix Tabs root wrappers."horizontal".Validation
npx pnpm@9.0.6 install --frozen-lockfilenpx pnpm@9.0.6 --filter=shadcn buildnpx pnpm@9.0.6 --filter=v4 typechecknpx pnpm@9.0.6 --filter=v4 validate:registriesnpx pnpm@9.0.6 --filter=v4 lintnpx pnpm@9.0.6 --filter=v4 format:checkgit diff --checkFixes #10592.