Skip to content

fix: support asChild in SelectTrigger#10662

Open
raashish1601 wants to merge 1 commit into
shadcn-ui:mainfrom
raashish1601:codex/8075-select-trigger-as-child
Open

fix: support asChild in SelectTrigger#10662
raashish1601 wants to merge 1 commit into
shadcn-ui:mainfrom
raashish1601:codex/8075-select-trigger-as-child

Conversation

@raashish1601
Copy link
Copy Markdown

Summary

  • Avoid rendering the built-in select chevron as a sibling when SelectTrigger is used with asChild.
  • Preserve the default chevron icon for the normal trigger path.
  • Regenerate the v4 Radix style outputs and public registry JSON.
  • Add regression coverage for the single-child asChild contract.

Fixes #8075.

Tests

  • corepack pnpm exec vitest run apps/v4/registry/select-trigger.test.tsx
  • corepack pnpm --filter=v4 lint
  • corepack pnpm --filter=v4 typecheck
  • corepack pnpm --filter=shadcn build
  • corepack pnpm dlx bun run ./scripts/build-registry.mts from apps/v4
  • corepack pnpm exec prettier --check <changed files>
  • git diff --check

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 15, 2026

@raashish1601 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: SelectTrigger throws an error with asChild={true}.

1 participant