Fix default Tailwind v4 registry fallback#10661
Open
raashish1601 wants to merge 1 commit into
Open
Conversation
Contributor
|
@raashish1601 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultstyle with an empty Tailwind config the same asnew-york, resolving it to the Tailwind v4 fallback style.defaultfalls back only for Tailwind v4 configless projects, while legacy config-file projects and custom styles are preserved.This addresses the
styles/default/combobox.json404 path reported in #10065 without changing legacydefaultprojects that still have a Tailwind config file.Test plan
corepack pnpm exec vitest run packages/shadcn/src/registry/config.test.tscorepack pnpm --filter shadcn typecheckcorepack pnpm exec prettier --check packages/shadcn/src/registry/config.ts packages/shadcn/src/registry/config.test.tscorepack pnpm --filter shadcn buildgit diff --checkNotes:
corepack pnpm exec eslint packages/shadcn/src/registry/config.ts packages/shadcn/src/registry/config.test.tsis currently blocked locally because the repo has legacy.eslintrc.jsonconfig while the installed ESLint 9 CLI expectseslint.config.*.corepack pnpm --filter shadcn testhas existing Windows-specific path snapshot/local-file failures outside this change; the targeted registry config test passed.