fix(v4): forward refs in Button asChild variants#10660
Open
raashish1601 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Raashish Aggarwal <94279692+raashish1601@users.noreply.github.com>
Contributor
|
@raashish1601 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8930.
Buttonvariants toReact.forwardRefcomponents.Slot.RootwhenasChildis used, preserving composition with Tooltip and other slot-based primitives.Button asChildrenders only the child element and does not wrap it in a nested<button>.Validation
corepack pnpm vitest run apps/v4/registry/new-york-v4/ui/button.test.tsx apps/v4/registry/bases/radix/ui/button.test.tsxcorepack pnpm --filter=v4 typecheckcorepack pnpm --filter=v4 lintcorepack pnpm --filter=v4 validate:registriescorepack pnpm --filter=shadcn buildgit diff --check origin/main...HEADNotes
corepack pnpm --filter=v4 buildcould not complete in my local Windows environment because the script invokes barepnpmand this machine only exposes pnpm through Corepack. Attempting the registry step manually withtsxalso fails before this change is exercised because the script expects Bun's JSX runtime and Bun is not installed locally.