fix(cli): allow esbuild builds in Vite templates#10659
Open
raashish1601 wants to merge 1 commit into
Open
Conversation
Contributor
|
@raashish1601 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10658.
allowBuilds.esbuildconfig to the Vite app and Vite monorepo templates so pnpm 11 can run esbuild's postinstall during the first install.packages:workspace entries.Validation
corepack pnpm --filter=shadcn exec vitest run src/utils/scaffold.test.tscorepack pnpm --filter=shadcn typecheckcorepack pnpm --filter=shadcn buildcorepack pnpm exec prettier --check --end-of-line lf templates/vite-app/pnpm-workspace.yaml templates/vite-monorepo/pnpm-workspace.yaml packages/shadcn/src/templates/create-template.ts packages/shadcn/src/utils/scaffold.test.tsgit diff --checktemplates/vite-app:corepack pnpm@11.1.2 install --no-frozen-lockfile --dir <tmp>; esbuild postinstall ran and no ignored-build-script output was reported.templates/vite-monorepo:corepack pnpm install --no-frozen-lockfile --dir <tmp>; pinned pnpm 9.15.9 install completed and no ignored-build-script output was reported.Notes
corepack pnpm --filter=shadcn testwas also run on Windows. The full suite currently has unrelated Windows path/local-file failures in tests such asmigrate-radix,env-helpers,registry/api,registry/resolver, andupdate-files; the scaffold test covering this change passes.