feat: track client cover size preference and prefetch on album/song responses#691
Open
brian-doherty wants to merge 2 commits into
Open
feat: track client cover size preference and prefetch on album/song responses#691brian-doherty wants to merge 2 commits into
brian-doherty wants to merge 2 commits into
Conversation
f7c8c0b to
c3332c4
Compare
…esponses Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
c3332c4 to
ff596f1
Compare
Owner
|
thanks Brain this is interesting, though I have a couple comments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClientCoverSizePreferenceDB table (with migration) that records the last cover art size requested by each user+client pair, updated on everygetCoverArtcallensureCoverCachedfromServeGetCoverArtso the resize+save logic is reusableresphandler inNew()with a local closure that callsprefetchCoversafter any successful album/song response — no changes to individual handlers requiredprefetchCoverslooks up the stored size preference for the requesting client and pre-warms the cover cache for all album/track IDs in the response (deduplicated, each in its own goroutine)Test plan
getCoverArtrecords size preference in DBgetAlbum/getAlbumList/search3etc. responses trigger background cache warming at the stored sizegetCoverArtcall without re-encoding🤖 Generated with Claude Code