Skip to content

fix(alertmanager): replace hardcoded externalUrl with dynamic ingress endpoint #4913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eve-scality wants to merge 2 commits into
base: development/133.0
Choose a base branch
from
+7 −1
Open

fix(alertmanager): replace hardcoded externalUrl with dynamic ingress endpoint #4913

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e8ac6c
fix(alertmanager): replace hardcoded externalUrl with dynamic ingress…
May 6, 2026
221ce35
fix(alertmanager): set externalUrl in chart values and regenerate cha…
May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion salt/metalk8s/addons/prometheus-operator/deployed/chart.sls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
{%- set grafana = salt.metalk8s_service_configuration.get_service_conf('metalk8s-monitoring', 'metalk8s-grafana-config', grafana_defaults) %}
{%- set prometheus = salt.metalk8s_service_configuration.get_service_conf('metalk8s-monitoring', 'metalk8s-prometheus-config', prometheus_defaults) %}
{%- set alertmanager = salt.metalk8s_service_configuration.get_service_conf('metalk8s-monitoring', 'metalk8s-alertmanager-config', alertmanager_defaults) %}
{%- set cp_ingress_ep = salt.metalk8s_network.get_control_plane_ingress_endpoint() %}

{% raw %}

Expand Down Expand Up @@ -80316,7 +80317,7 @@ spec:
alertmanagerConfigNamespaceSelector: {}
alertmanagerConfigSelector: {}
automountServiceAccountToken: true
Comment thread
JBWatenbergScality marked this conversation as resolved.
externalUrl: http://prometheus-operator-alertmanager.metalk8s-monitoring:9093
externalUrl: {% endraw -%}{{ cp_ingress_ep }}{%- raw %}/api/alertmanager
Copy link
Copy Markdown
Contributor

@JBWatenbergScality JBWatenbergScality May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
externalUrl: {% endraw -%}{{ cp_ingress_ep }}{%- raw %}/api/alertmanager
externalUrl: {% endraw -%}{{ cp_ingress_ep }}{%- raw %}

hostNetwork: false
image: {% endraw -%}{{ repo.registry_endpoint }}{%- raw %}/{% endraw -%}{{ build_image_name("alertmanager", False, False) }}{%- raw %}:v0.31.1
imagePullPolicy: IfNotPresent
Expand Down
Loading