Skip to content

HIVE-29598 follow-up: virtualize clearValue + replace qtest #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryukobayashi merged 1 commit into from
May 19, 2026
Merged

HIVE-29598 follow-up: virtualize clearValue + replace qtest #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 4 additions & 37 deletions ...g/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterGenerateResultOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,7 @@
import org.apache.hadoop.hive.ql.exec.persistence.MapJoinTableContainer;
import org.apache.hadoop.hive.ql.exec.vector.BytesColumnVector;
import org.apache.hadoop.hive.ql.exec.vector.ColumnVector;
import org.apache.hadoop.hive.ql.exec.vector.DecimalColumnVector;
import org.apache.hadoop.hive.ql.exec.vector.DoubleColumnVector;
import org.apache.hadoop.hive.ql.exec.vector.IntervalDayTimeColumnVector;
import org.apache.hadoop.hive.ql.exec.vector.LongColumnVector;
import org.apache.hadoop.hive.ql.exec.vector.TimestampColumnVector;
import org.apache.hadoop.hive.ql.exec.vector.VectorizationContext;
import org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch;
import org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression;
Expand Down Expand Up @@ -591,18 +587,12 @@ protected void generateOuterNulls(VectorizedRowBatch batch, int[] noMatchs,
// key as null, too.
//
for (int column : outerSmallTableKeyColumnMap) {
ColumnVector colVector = batch.cols[column];
colVector.noNulls = false;
colVector.isNull[batchIndex] = true;
clearVectorValue(colVector, batchIndex);
batch.cols[column].clearValue(batchIndex);
}

// Small table values are set to null.
for (int column : smallTableValueColumnMap) {
ColumnVector colVector = batch.cols[column];
colVector.noNulls = false;
colVector.isNull[batchIndex] = true;
clearVectorValue(colVector, batchIndex);
batch.cols[column].clearValue(batchIndex);
}
}
}
Expand Down Expand Up @@ -752,37 +742,14 @@ protected void generateOuterNullsRepeatedAll(VectorizedRowBatch batch) throws Hi
//
for (int column : outerSmallTableKeyColumnMap) {
ColumnVector colVector = batch.cols[column];
colVector.noNulls = false;
colVector.isNull[0] = true;
colVector.clearValue(0);
colVector.isRepeating = true;
clearVectorValue(colVector, 0);
}

for (int column : smallTableValueColumnMap) {
ColumnVector colVector = batch.cols[column];
colVector.noNulls = false;
colVector.isNull[0] = true;
colVector.clearValue(0);
colVector.isRepeating = true;
clearVectorValue(colVector, 0);
}
}

private static void clearVectorValue(ColumnVector colVector, int index) {
if (colVector instanceof LongColumnVector) {
((LongColumnVector) colVector).vector[index] = 0L;
} else if (colVector instanceof DoubleColumnVector) {
((DoubleColumnVector) colVector).vector[index] = 0.0;
} else if (colVector instanceof BytesColumnVector) {
BytesColumnVector bcv = (BytesColumnVector) colVector;
bcv.vector[index] = null;
bcv.start[index] = 0;
bcv.length[index] = 0;
} else if (colVector instanceof DecimalColumnVector) {
((DecimalColumnVector) colVector).vector[index].setFromLong(0L);
} else if (colVector instanceof TimestampColumnVector) {
((TimestampColumnVector) colVector).setNullValue(index);
} else if (colVector instanceof IntervalDayTimeColumnVector) {
((IntervalDayTimeColumnVector) colVector).setNullValue(index);
}
}

Expand Down
Loading