Skip to content

fix: stabilize object drawer dialogs#121

Merged
cxymds merged 1 commit into
mainfrom
codex/fix-object-dialog-drawer-issue-3006
May 19, 2026
Merged

fix: stabilize object drawer dialogs#121
cxymds merged 1 commit into
mainfrom
codex/fix-object-dialog-drawer-issue-3006

Conversation

@cxymds
Copy link
Copy Markdown
Member

@cxymds cxymds commented May 19, 2026

Pull Request

Description

Fixes the object details drawer/dialog interaction regressions reported in rustfs/rustfs#3006:

  • Prevent nested tag, retention, and version dialogs from treating internal button/input interactions as outside dismissal.
  • Fix tag add/delete to use the resolved object key and explicit submit handlers.
  • Avoid nested button hydration errors in the task stats drawer trigger.
  • Restore full viewport height for left/right drawers.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvements
  • Security fix

Testing

  • Unit tests added/updated
  • Manual testing completed
pnpm install --frozen-lockfile
node --test tests/lib/drawer-source.test.js tests/lib/object-info-source.test.js tests/lib/dialog-source.test.js tests/lib/task-stats-button-source.test.js
pnpm prettier --check components/ui/dialog.tsx components/ui/drawer.tsx components/object/info.tsx components/object/versions.tsx tests/lib/object-info-source.test.js tests/lib/dialog-source.test.js tests/lib/drawer-source.test.js tests/lib/task-stats-button-source.test.js
pnpm tsc --noEmit
pnpm lint

Note: this package does not currently define a pnpm test:run script.

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • TypeScript types are properly defined
  • All commit messages are in English (Conventional Commits)
  • All existing targeted tests pass
  • No new dependencies added, or they are justified

Related Issues

Fixes rustfs/rustfs#3006

Screenshots (if applicable)

Not included.

Additional Notes

The commit also includes Fixes rustfs/rustfs#3006 for issue association.

Fix tag editing, version preview, nested dialog pointer handling, and right drawer height in the object details workflow.

Fixes rustfs/rustfs#3006
@cxymds cxymds merged commit 7889bb7 into main May 19, 2026
11 checks passed
@cxymds cxymds deleted the codex/fix-object-dialog-drawer-issue-3006 branch May 19, 2026 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Web Console fails to load object details and set tags due to 400 Bad Request on retention and legal-hold APIs

1 participant