Skip to content

filter 0 counts from pie chart colors#84

Open
tlugger wants to merge 2 commits into
robherley:mainfrom
tlugger:pi-colors
Open

filter 0 counts from pie chart colors#84
tlugger wants to merge 2 commits into
robherley:mainfrom
tlugger:pi-colors

Conversation

@tlugger
Copy link
Copy Markdown
Contributor

@tlugger tlugger commented Apr 28, 2026

Fixes #72

The pie chart could have mismatched colors when some test conclusion types had 0 counts (e.g., no failures or no skips)

Creates consistent sequential pie indicies in renderer.ts

@robherley
Copy link
Copy Markdown
Owner

hey @tlugger, thanks for the contribution!

i'm not entirely convinced this was the failure mode, given the screenshot in #72 showed at least one test for each slice of the pie

also running the newly added tests (without the changes) still passes on main 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The pie filled wrong color

2 participants