Introduce new behavior for run completion proposals#4737
Open
slinkydeveloper wants to merge 3 commits into
Open
Introduce new behavior for run completion proposals#4737slinkydeveloper wants to merge 3 commits into
slinkydeveloper wants to merge 3 commits into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
slinkydeveloper
force-pushed
the
issues/ack-completion-proposal
branch
3 times, most recently
from
5de8f93 to
131a240
Compare
Contributor
Author
|
Tested against this restatedev/sdk-typescript#719 and this restatedev/sdk-shared-core#79 |
…e now send back an ad-hoc message indicating an ack for the completion proposal, instead than sending back the full completion.
…2e repo detects them
slinkydeveloper
force-pushed
the
issues/ack-completion-proposal
branch
from
131a240 to
ab28369
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in protocol v7 we now send back an ad-hoc message indicating an ack for the completion proposal, instead than sending back the full completion.
Fix #4440