Correct sort order for tables with variable length key fields#4734
Merged
Conversation
Contributor
Author
|
I am probably misunderstanding the |
igalshilman
approved these changes
May 14, 2026
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
The problem is that variable length key fields are length encoded so that the length of the field decides its order and not the value. Hence, shorter values precede longer values which should violate DF sort order assumption.
tillrohrmann
force-pushed
the
fix-sort-order
branch
from
a058bea to
c4b96f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is that variable length key fields are length encoded so that the length of the field decides its order and not the value. Hence, shorter values precede longer values which should violate DF sort order assumption.