Skip to content

wal-protocol: extract v1 Envelope into a dedicated module#4694

Merged
muhamadazmy merged 1 commit into
mainfrom
pr4694
May 7, 2026
Merged

wal-protocol: extract v1 Envelope into a dedicated module#4694
muhamadazmy merged 1 commit into
mainfrom
pr4694

Conversation

@muhamadazmy
Copy link
Copy Markdown
Contributor

@muhamadazmy muhamadazmy commented May 5, 2026

wal-protocol: extract v1 Envelope into a dedicated module

Summary:

Move the existing Envelope, Header, Source, Destination, and Command
types out of wal-protocol/src/lib.rs into a new v1 submodule, and
re-export them from the crate root for backward compatibility.

This is a pure refactor — no behavior or wire-format change — that
prepares the crate for the upcoming v2 envelope by carving out a
clear namespace for the legacy types.


Stack created with Sapling. Best reviewed with ReviewStack.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Test Results

  8 files  + 1    8 suites  +1   4m 38s ⏱️ + 1m 51s
 50 tests + 3   50 ✅ + 3  0 💤 ±0  0 ❌ ±0 
218 runs  +18  218 ✅ +18  0 💤 ±0  0 ❌ ±0 

Results for commit e375998. ± Comparison against base commit b128276.

This pull request removes 4 and adds 7 tests. Note that renamed tests count towards both.
dev.restate.sdktesting.tests.KafkaIngress ‑ handleEventInCounterService(URI, int, Client)
dev.restate.sdktesting.tests.KafkaIngress ‑ handleEventInEventHandler(URI, int, Client)
dev.restate.sdktesting.tests.UpgradeWithInFlightInvocation ‑ inFlightInvocation(Client, URI)
dev.restate.sdktesting.tests.UpgradeWithNewInvocation ‑ executesNewInvocationWithLatestServiceRevisions(Client, URI)
dev.restate.sdktesting.tests.Combinators ‑ awakeableOrTimeoutUsingAwaitAny(Client)
dev.restate.sdktesting.tests.Combinators ‑ firstSuccessfulCompletedAwakeable(Client)
dev.restate.sdktesting.tests.Custom ‑ run(CustomTestConfig, URI, URI)[1]
dev.restate.sdktesting.tests.UserErrors ‑ failSeveralTimesWithMetadata(URI)
dev.restate.sdktesting.tests.UserErrors ‑ internalCallFailurePropagationWithMetadata(URI)
dev.restate.sdktesting.tests.UserErrors ‑ invokeTerminallyFailingCallWithMetadata(URI)
dev.restate.sdktesting.tests.UserErrors ‑ sideEffectWithTerminalErrorWithMetadata(URI)

♻️ This comment has been updated with latest results.

@muhamadazmy muhamadazmy changed the title Move Envelope to v1 wal-protocol: extract v1 Envelope into a dedicated module May 7, 2026
@muhamadazmy muhamadazmy marked this pull request as ready for review May 7, 2026 13:48
@muhamadazmy muhamadazmy requested a review from AhmedSoliman May 7, 2026 13:48
# Summary:
Move the existing Envelope, Header, Source, Destination, and Command
types out of `wal-protocol/src/lib.rs` into a new `v1` submodule, and
re-export them from the crate root for backward compatibility.

This is a pure refactor — no behavior or wire-format change — that
prepares the crate for the upcoming v2 envelope by carving out a
clear namespace for the legacy types.
@muhamadazmy muhamadazmy merged commit 1f91364 into main May 7, 2026
59 checks passed
@muhamadazmy muhamadazmy deleted the pr4694 branch May 7, 2026 15:38
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants