wal-protocol: extract v1 Envelope into a dedicated module#4694
Merged
Conversation
This was referenced May 5, 2026
Test Results 8 files + 1 8 suites +1 4m 38s ⏱️ + 1m 51s Results for commit e375998. ± Comparison against base commit b128276. This pull request removes 4 and adds 7 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Envelope to v1
AhmedSoliman
approved these changes
May 7, 2026
# Summary: Move the existing Envelope, Header, Source, Destination, and Command types out of `wal-protocol/src/lib.rs` into a new `v1` submodule, and re-export them from the crate root for backward compatibility. This is a pure refactor — no behavior or wire-format change — that prepares the crate for the upcoming v2 envelope by carving out a clear namespace for the legacy types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wal-protocol: extract v1 Envelope into a dedicated module
Summary:
Move the existing Envelope, Header, Source, Destination, and Command
types out of
wal-protocol/src/lib.rsinto a newv1submodule, andre-export them from the crate root for backward compatibility.
This is a pure refactor — no behavior or wire-format change — that
prepares the crate for the upcoming v2 envelope by carving out a
clear namespace for the legacy types.
Stack created with Sapling. Best reviewed with ReviewStack.