-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
gh-122931 Allow stable API extensions to include a multiarch tuple in the filename #122917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 3 commits
735f8af
25cc5ae
81f5862
09ae8d5
7b071c2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Allow importing stable ABI C extensions that include a multiarch tuple | ||
| in their filename, e.g. ``foo.abi3-x86-64-linux-gnu.so``. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,8 +46,14 @@ const char *_PyImport_DynLoadFiletab[] = { | |
| "." ALT_SOABI ".so", | ||
| #endif | ||
| #ifndef Py_GIL_DISABLED | ||
| #ifdef SOABI_PLATFORM | ||
| ".abi" PYTHON_ABI_STRING "-" SOABI_PLATFORM ".so", | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just defined the lower level configure variable that |
||
| #endif /* SOABI_PLATFORM */ | ||
| ".abi" PYTHON_ABI_STRING ".so", | ||
| #endif /* Py_GIL_DISABLED */ | ||
| #ifdef SOABI_PLATFORM | ||
| ".abi" PYTHON_ABI_STRING "t-" SOABI_PLATFORM ".so", | ||
| #endif /* SOABI_PLATFORM */ | ||
| ".abi" PYTHON_ABI_STRING "t.so", | ||
| ".so", | ||
| #endif /* __CYGWIN__ */ | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1212,6 +1212,8 @@ AS_CASE([$ac_sys_system], | |
| [SOABI_PLATFORM=$PLATFORM_TRIPLET] | ||
| ) | ||
|
|
||
| AC_DEFINE_UNQUOTED([SOABI_PLATFORM], ["${SOABI_PLATFORM}"], [Platform tag, used in binary module extension filenames.]) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This renders as a double-escaped string in |
||
|
|
||
| if test x$MULTIARCH != x; then | ||
| MULTIARCH_CPPFLAGS="-DMULTIARCH=\\\"$MULTIARCH\\\"" | ||
| fi | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.