Skip to content
This repository was archived by the owner on May 14, 2026. It is now read-only.

chore(cli): --save-dev with --save-prod implies as dev#216

Open
await-ovo wants to merge 1 commit into
pnpm:mainfrom
await-ovo:fix-save-dev-prod
Open

chore(cli): --save-dev with --save-prod implies as dev#216
await-ovo wants to merge 1 commit into
pnpm:mainfrom
await-ovo:fix-save-dev-prod

Conversation

@await-ovo
Copy link
Copy Markdown
Member

Behavior consistent with pnpm when --save-dev with --save-prod:

pnpm add some-pkg --save-prod --save-dev will only be installed as devDependencies.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 23, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.64%. Comparing base (c62a631) to head (75315ef).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
- Coverage   92.65%   92.64%   -0.02%     
==========================================
  Files          57       57              
  Lines        2847     2856       +9     
==========================================
+ Hits         2638     2646       +8     
- Misses        209      210       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSXGitHub
Copy link
Copy Markdown
Contributor

I think pnpm is in the wrong in this case, but no one cares enough to fix it yet.

What's your opinion, @zkochan?

@zkochan
Copy link
Copy Markdown
Member

zkochan commented Nov 28, 2023

How would you expect it to work at all? I would throw an error in this case.

@zkochan zkochan self-requested a review as a code owner May 12, 2026 20:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants