docs(react): add Action constraint to redux middleware signature#3492
Merged
dbritto-dev merged 2 commits intoMay 20, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dbritto-dev
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
reduxmiddleware signature in the reference docs is missing theActionconstraint that's present insrc/middleware/redux.ts:Without the constraint, the docs allow
Ato be any type. With the constraint, TypeScript enforces thataction.typeis accessible — which is the whole point of the redux pattern (action discriminator).Diff
Single change:
<T, A>→<T, A extends { type: string }>.This is part of an ongoing pass over the reference docs to align signatures with source — see #3487, #3489, #3491.
Docs-only — no changeset needed.