Skip to content

wtf-bindings: use WTF ASSERT() so debug builds compile #30992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 4 commits into
base: main
Choose a base branch
from

terminal.test: pick ICANON per-platform (0x100 on darwin)

4262bbc
Select commit
Loading
Failed to load commit list.
Open

wtf-bindings: use WTF ASSERT() so debug builds compile #30992

terminal.test: pick ICANON per-platform (0x100 on darwin)
4262bbc
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed May 18, 2026 in 17m 13s

Code review found 1 potential issue

Found 1 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit test/js/bun/terminal/terminal.test.ts:290-292 Comment groups BSD on wrong side of ICANON value

Annotations

Check warning on line 292 in test/js/bun/terminal/terminal.test.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

Comment groups BSD on wrong side of ICANON value 

Tiny nit: the comment says "ICANON is 0x2 on Linux/BSD but 0x100 on Darwin", but BSD is on the wrong side — FreeBSD/NetBSD/OpenBSD all use `0x100` (Darwin inherited BSD termios), only Linux uses `0x2`. The review comment this responds to even said "on macOS/BSD, ICANON is 0x100". No functional impact since Bun only targets linux/darwin/windows; consider just dropping "/BSD" or moving it to the Darwin side.
View more details on Claude