lexer: step past unknown byte on TSyntaxError in next_inside_jsx_element #30969
+73
−3
Claude / Claude Code Review
completed
May 18, 2026 in 12m 55s
Code review found 1 potential issue
Found 6 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/regression/issue/jsx-template-string-crash.test.ts:39-41 |
Stale test comment describes reverted fix approach |
Annotations
Check warning on line 41 in test/regression/issue/jsx-template-string-crash.test.ts
claude / Claude Code Review
Stale test comment describes reverted fix approach
This comment (and the PR title/description) describes the reverted `orig_error_count` approach from 2b1dc3b9/bc00e5d1 — "the debug assertion is now relaxed once an error has been logged" is no longer true. d1a40fcb reverted the p.rs guard; the shipped fix is `self.step()` in `next_inside_jsx_element` (lexer.rs:3064), which prevents the duplicate scope offset from arising at all. The assertion in `push_scope_for_parse_pass` is *not* relaxed and would still fire on a duplicate offset. Worth reword
Loading