-
Notifications
You must be signed in to change notification settings - Fork 4.6k
spawnSync: do not forward SIGPWR on Linux #30956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robobun
wants to merge
5
commits into
main
Choose a base branch
from
farm/a5eb0a5e/spawnsync-sigpwr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+72
−4
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4b9d469
spawnSync: do not forward SIGPWR on Linux
robobun ac02046
[autofix.ci] apply automated fixes
autofix-ci[bot] 1b8f2ae
ci: retrigger
robobun 2d5b42e
test: drop negative crash-marker assertion
robobun 7e2c283
spawnSync: make signal-forwarding register/unregister reentrant
robobun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| import { expect, test } from "bun:test"; | ||
| import { bunEnv, bunExe, tempDir, isLinux } from "harness"; | ||
| import { join } from "path"; | ||
| import { symlinkSync } from "fs"; | ||
|
|
||
| // Regression: spawnSync's signal-forwarding list included SIGPWR on Linux. | ||
| // JSC uses SIGPWR to suspend/resume threads for GC. Bun.openInEditor spawns a | ||
| // detached thread per call that runs spawnSync; concurrent calls race on the | ||
| // process-wide previous-handler table and can leave SIGPWR at SIG_DFL. The | ||
| // next GC suspend then terminates the process with signal 30. | ||
| test.skipIf(!isLinux)( | ||
| "spawnSync signal forwarding does not clobber JSC's SIGPWR handler", | ||
| async () => { | ||
| const sleepBin = Bun.which("sleep"); | ||
| expect(sleepBin).toBeTruthy(); | ||
|
|
||
| using dir = tempDir("spawnSync-sigpwr", { | ||
| "run.js": ` | ||
| for (let i = 0; i < 64; i++) { | ||
| try { Bun.openInEditor("0.2"); } catch {} | ||
| } | ||
| let junk = []; | ||
| for (let i = 0; i < 2000; i++) { | ||
| junk.push({ a: new Uint8Array(4096).fill(i), b: { c: i } }); | ||
| } | ||
| for (let i = 0; i < 30; i++) Bun.gc(true); | ||
| console.log("ok"); | ||
| `, | ||
| }); | ||
| // Make `code` (first in the editor preference list) resolve to `sleep`, so | ||
| // each background spawnSync holds its signal-forwarding window open long | ||
| // enough for threads to overlap. | ||
| symlinkSync(sleepBin!, join(String(dir), "code")); | ||
|
|
||
| await using proc = Bun.spawn({ | ||
| cmd: [bunExe(), join(String(dir), "run.js")], | ||
| env: { | ||
| ...bunEnv, | ||
| PATH: String(dir), | ||
| EDITOR: "", | ||
| VISUAL: "", | ||
| }, | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
|
|
||
| const [stdout, stderr, exitCode] = await Promise.all([ | ||
| proc.stdout.text(), | ||
| proc.stderr.text(), | ||
| proc.exited, | ||
| ]); | ||
|
|
||
| expect(proc.signalCode).toBeNull(); | ||
| expect(stderr).not.toContain("AddressSanitizer"); | ||
| expect(stdout.trim()).toBe("ok"); | ||
| expect(exitCode).toBe(0); | ||
| }, | ||
| ); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.