Skip to content

fs: reject async iterator with ERR_STREAM_PREMATURE_CLOSE when destroy() is called during iteration #30920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 6 commits into
base: main
Choose a base branch
from

fs: remove dead kReadStreamFastPath references

69f503d
Select commit
Loading
Failed to load commit list.
Open

fs: reject async iterator with ERR_STREAM_PREMATURE_CLOSE when destroy() is called during iteration #30920

fs: remove dead kReadStreamFastPath references
69f503d
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed May 18, 2026 in 15m 2s

Code review found 1 potential issue

Found 3 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit src/js/internal/fs/streams.ts:201-204 Unused 'encoding' local left in ReadStream constructor destructure

Annotations

Check warning on line 204 in src/js/internal/fs/streams.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

Unused 'encoding' local left in ReadStream constructor destructure 

Nit: now that 69f503da removed the `this[kReadStreamFastPath] = ...` assignment, the `encoding` local destructured at L139 (`let { fd, autoClose, fs: customFs, start, end = Infinity, encoding } = options;`) is never read in the `ReadStream` constructor — that assignment was its only consumer. Drop `encoding` from the destructure (the stream's encoding is still applied via `Readable.$call(this, options)`, so no behavior change).
View more details on Claude