Skip to content

Update location for go-grpc. #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yurishkuro merged 1 commit into from
May 18, 2018
Merged

Update location for go-grpc. #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ The following are all on the OpenTracing instrumentation short-list:
- [x] [Finagle](https://github.com/twitter/finagle/pull/520#issuecomment-249959538)... almost :confused:
- [x] [Flask](https://github.com/opentracing-contrib/python-flask)
- [ ] gRPC:
- [x] [Go](https://github.com/grpc-ecosystem/grpc-opentracing/tree/master/go/otgrpc)
Copy link
Copy Markdown
Contributor

@yurishkuro yurishkuro May 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened to to https://github.com/grpc-ecosystem/grpc-opentracing/ ? Should it be archived and README updated to refer to opentracing-contrib/go-grpc ?

Copy link
Copy Markdown
Contributor Author

@rnburn rnburn May 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That repository wasn't being maintained well.

Not many people had write access and grouping all the languages into one repo meant that a lot of the issues were being ignored. See @tedsuo's comments: https://gitter.im/opentracing/public?at=5a32ca19ba39a53f1a5f481a

But I also put in a PR to redirect go from there: grpc-ecosystem/grpc-opentracing#43

- [x] [Go](https://github.com/opentracing-contrib/go-grpc)
- [x] [Java](https://github.com/opentracing-contrib/java-grpc)
- [x] [Python](https://github.com/opentracing-contrib/python-grpc)
- [ ] Ruby
Expand Down