fix(otel-upstream): use opentelemetry-operator-system namespace in upstream step#79419
Conversation
The OpenTelemetry Operator upstream e2e tests now install the operator into opentelemetry-operator-system (the OLM default) instead of the old opentelemetry-operator namespace. Update all oc -n and CSV patch commands in the upstream step to match. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughCI workflows and distributed-tracing test scripts were updated to use the ChangesOpenTelemetry CSV Namespace Migration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Update the operator install namespace from opentelemetry-operator to opentelemetry-operator-system in the upstream OCP 4.12, 4.21, and 4.22 job configs. Aligns with the step script change and the upstream operator repo standardization. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PROJECT_NAME is consumed by the Snyk SAST step as the Snyk project name, not as an OCP namespace. Revert the inadvertent rename. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
/pj-rehearse ack |
|
@IshwarKanse: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
The TLS profile tests patch the cluster-wide APIServer resource, triggering node-level TLS reconciliation that disrupts concurrently running tests. Run them as a separate chainsaw invocation after all other suites complete, matching the same any_errors pattern used in the OTel upstream test step. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
/pj-rehearse ack |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@IshwarKanse: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: IshwarKanse, kabirbhartiRH The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@IshwarKanse: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…stream step (openshift#79419) * fix(otel-upstream): use opentelemetry-operator-system namespace The OpenTelemetry Operator upstream e2e tests now install the operator into opentelemetry-operator-system (the OLM default) instead of the old opentelemetry-operator namespace. Update all oc -n and CSV patch commands in the upstream step to match. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(otel-upstream): use opentelemetry-operator-system in job configs Update the operator install namespace from opentelemetry-operator to opentelemetry-operator-system in the upstream OCP 4.12, 4.21, and 4.22 job configs. Aligns with the step script change and the upstream operator repo standardization. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(otel-upstream): revert PROJECT_NAME to opentelemetry-operator PROJECT_NAME is consumed by the Snyk SAST step as the Snyk project name, not as an OCP namespace. Revert the inadvertent rename. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Run Tempo TLS profile tests last as an isolated chainsaw invocation The TLS profile tests patch the cluster-wide APIServer resource, triggering node-level TLS reconciliation that disrupts concurrently running tests. Run them as a separate chainsaw invocation after all other suites complete, matching the same any_errors pattern used in the OTel upstream test step. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary
Update the OpenTelemetry operator install namespace from `opentelemetry-operator` to `opentelemetry-operator-system` across the upstream CI step and job configs. This aligns with the change in open-telemetry/opentelemetry-operator#5085 which standardizes all OpenShift e2e tests to use `opentelemetry-operator-system` (the OLM default namespace).
Affected files
Step script:
Job configs:
🤖 Generated with Claude Code
Summary
This PR updates OpenShift CI configuration and an upstream distributed-tracing step script in the openshift/release repository so OpenTelemetry upstream install and e2e test steps use the OLM-default namespace opentelemetry-operator-system instead of opentelemetry-operator.
What changed (practical effect)
Step-registry script:
Upstream job configs:
Why
OLM now installs the OpenTelemetry operator into opentelemetry-operator-system by default (upstream change). Aligning CI install and test steps with the upstream default prevents tests from targeting the wrong namespace and failing.
Impact