AGENT-1429: Add HA Dualstack periodic job for ISO_NO_REGISTRY#79360
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@pawanpinjarkar: This pull request references AGENT-1429 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThis PR updates CI job configuration for nightly OpenShift release testing. The existing compact ISO test runs more frequently (every 8 hours instead of 12), and a new HA dualstack ISO test job is added with identical schedule and TechPreview feature set configuration on the equinix-ocp-metal cluster profile. ChangesCI Test Job Configuration Updates
🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
|
/cc @bfournie |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml (1)
2148-2160: 💤 Low valueConsider staggering the cron schedule to avoid potential resource contention on equinix-ocp-metal.
The new job
e2e-agent-ha-dualstack-iso-no-registry-techpreviewruns on the same schedule (0 */8 * * *) and cluster profile ase2e-agent-compact-iso-no-registry-techpreview, both triggering at 00:00, 08:00, and 16:00 UTC. If concurrent execution is not required, consider offsetting one to distribute load.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml` around lines 2148 - 2160, The job e2e-agent-ha-dualstack-iso-no-registry-techpreview is scheduled at the same cron (0 */8 * * *) as e2e-agent-compact-iso-no-registry-techpreview causing potential concurrent runs; update the cron value for one of these jobs (the cron field under the job block) to an offset schedule (for example shift to 2 */8 * * * or 4 */8 * * *) to stagger execution on equinix-ocp-metal, then save the updated cron string so the two jobs no longer run at the same UTC times.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml`:
- Around line 2148-2160: The job
e2e-agent-ha-dualstack-iso-no-registry-techpreview is scheduled at the same cron
(0 */8 * * *) as e2e-agent-compact-iso-no-registry-techpreview causing potential
concurrent runs; update the cron value for one of these jobs (the cron field
under the job block) to an offset schedule (for example shift to 2 */8 * * * or
4 */8 * * *) to stagger execution on equinix-ocp-metal, then save the updated
cron string so the two jobs no longer run at the same UTC times.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 53967671-cdd0-4b71-a474-5929a06b4202
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/release/openshift-release-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
|
/lgtm |
|
/pj-rehearse |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha-dualstack-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha-dualstack-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha-dualstack-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
agent-gather is failing due to connectivity issue |
|
/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha-dualstack-iso-no-registry-techpreview |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@pawanpinjarkar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/approve |
|
/approved |
|
/cc @smg247 please approve |
|
/assign @@smg247 |
|
/assign @smg247 |
|
@pawanpinjarkar: GitHub didn't allow me to request PR reviews from the following users: approve, please. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, bfournie, pawanpinjarkar, smg247 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@pawanpinjarkar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
e2e-agent-ha-dualstack-iso-no-registry-techpreviewto run HA Dualstack for ISO_NO_REGISTRY.This PR updates the OpenShift Release nightly 5.0 CI configuration to enhance testing of the Assisted Installer component with baremetal deployments.
Changes to the release configuration:
Increased test frequency: The existing
e2e-agent-compact-iso-no-registry-techpreviewperiodic job's execution frequency was increased from every 12 hours (0 */12 * * *) to every 8 hours (0 */8 * * *), enabling more frequent validation of compact cluster deployments with ISO_NO_REGISTRY boot mode.New HA Dualstack test job: Added a new periodic job
e2e-agent-ha-dualstack-iso-no-registry-techpreviewthat validates High Availability cluster deployments with dual-stack IPv4/IPv6 networking using ISO_NO_REGISTRY boot mode. The job runs every 8 hours on the equinix-ocp-metal cluster profile with TechPreviewNoUpgrade feature set enabled.Both jobs test the Assisted Installer agent's ability to deploy OpenShift clusters using ISO images without an external container registry, addressing an important deployment scenario. The increased test frequency for compact deployments and the addition of HA dualstack testing improve validation coverage for different cluster topologies and network configurations.