Add ci-operator config for SNO day2-worker 4.18 CI lane#79357
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds a new CI-operator YAML that configures build/release roots and global resources, defines a cron-scheduled ChangesCNF RAN SNO Day2 Worker 4.18 CI Configuration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 12✅ Passed checks (12 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml`:
- Line 23: The cron entry "0 0 31 2 *" in the file
openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml is unschedulable
(February has no 31st); replace that cron expression with a valid schedule
(e.g., a valid February date like "0 0 28 2 *" or an alternative monthly
schedule) so the periodic lane actually runs, then follow the CI config workflow
by editing the file under ci-operator/config/<org>/<repo>/ and running make
update to regenerate downstream Prow job configs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: f0ce3fdd-ec34-46a8-badb-63682a312fe6
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml
| - as: cnf-ran-ztp-tests | ||
| capabilities: | ||
| - intranet | ||
| cron: 0 0 31 2 * |
There was a problem hiding this comment.
Cron schedule is unschedulable.
Line 23 uses 0 0 31 2 *, which never triggers (February has no 31st). This effectively disables the periodic lane.
Suggested fix
- cron: 0 0 31 2 *
+ cron: 0 0 * * *📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| cron: 0 0 31 2 * | |
| cron: 0 0 * * * |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml`
at line 23, The cron entry "0 0 31 2 *" in the file
openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml is unschedulable
(February has no 31st); replace that cron expression with a valid schedule
(e.g., a valid February date like "0 0 28 2 *" or an alternative monthly
schedule) so the periodic lane actually runs, then follow the CI config workflow
by editing the file under ci-operator/config/<org>/<repo>/ and running make
update to regenerate downstream Prow job configs.
There was a problem hiding this comment.
This is intentional, as we want to disable the job until the bug in the failed test is resolved upstream.
There was a problem hiding this comment.
🧩 Analysis chain
@rdiscala, understood! Using an impossible date like 0 0 31 2 * as a "dead cron" to intentionally park a periodic job is a recognized pattern in OpenShift CI. I'll resolve my comment and note this for future reviews.
🏁 Script executed:
#!/bin/bash
# Resolve the review comment made by coderabbitai[bot] on this PR
# First, list review comments on PR `#79357` to find the comment ID
gh api repos/openshift/release/pulls/79357/comments --jq '.[] | select(.user.login == "coderabbitai[bot]") | {id: .id, body: .body[0:80]}'
Length of output: 222
🏁 Script executed:
#!/bin/bash
# Resolve the review thread for comment ID 3250363928 using GraphQL
# First, get the pull request node ID and find the review thread
gh api graphql -f query='
{
repository(owner: "openshift", name: "release") {
pullRequest(number: 79357) {
reviewThreads(first: 50) {
nodes {
id
isResolved
comments(first: 1) {
nodes {
databaseId
body
}
}
}
}
}
}
}' --jq '.data.repository.pullRequest.reviewThreads.nodes[] | select(.comments.nodes[0].databaseId == 3250363928) | {threadId: .id, isResolved: .isResolved}'
Length of output: 56
🏁 Script executed:
#!/bin/bash
# Resolve the review thread using GraphQL mutation
gh api graphql -f query='
mutation {
resolveReviewThread(input: {threadId: "PRRT_kwDOBHvUUM6Cc3uz"}) {
thread {
id
isResolved
}
}
}'
Length of output: 266
@rdiscala, I wasn't able to resolve the comment programmatically due to repository permission restrictions. Could you please resolve it manually? The learning has been saved so this pattern won't be flagged in future reviews.
✏️ Learnings added
Learnt from: rdiscala
Repo: openshift/release PR: 79357
File: ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml:23-23
Timestamp: 2026-05-20T11:54:20.424Z
Learning: In OpenShift CI (openshift/release repository), using an impossible cron date such as `0 0 31 2 *` (February 31st) is an intentional pattern to effectively disable a periodic CI job without removing the configuration entirely. This is used to park a job while an upstream bug is being fixed. Do not flag this as an error during code review.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
|
/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-sno-day2-worker-4.18-cnf-ran-ztp-tests |
|
@rdiscala: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
rdiscala
force-pushed
the
TELCOV10N-1089-add-4.18-sno-day2-worker
branch
from
6983a25 to
d0fa40e
Compare
|
/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-sno-day2-worker-4.18-cnf-ran-ztp-tests |
|
@rdiscala: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
rdiscala
force-pushed
the
TELCOV10N-1089-add-4.18-sno-day2-worker
branch
from
d0fa40e to
1129a33
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rdiscala The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml`:
- Around line 46-47: The REPORTER_TEMPLATE_NAME value is split across lines with
a leading "- " which makes the YAML invalid; update the REPORTER_TEMPLATE_NAME
entry so the entire string is a single valid YAML scalar by either enclosing the
full value in quotes (e.g., "Telco 5G RAN Regression 4_18 - Telco 5G RAN
Regression - <build> - 4.18") or use a block scalar (|) to preserve line breaks,
ensuring the key REPORTER_TEMPLATE_NAME contains the intended multi-line or
single-line string without starting lines with "-" which would be interpreted as
a sequence item.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 6ec21a05-068d-4d04-98ca-aeaa100f6021
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__cnf-ran-sno-day2-worker-4.18.yaml
rdiscala
force-pushed
the
TELCOV10N-1089-add-4.18-sno-day2-worker
branch
2 times, most recently
from
17e1b4c to
c172d36
Compare
|
/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-sno-day2-worker-4.18-cnf-ran-ztp-tests |
|
@rdiscala: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
rdiscala
force-pushed
the
TELCOV10N-1089-add-4.18-sno-day2-worker
branch
from
c172d36 to
e6742fb
Compare
|
@rdiscala, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Adapts the existing 4.20 sno-day2-worker variant to OpenShift 4.18, using the same infrastructure (kni-qe-106 hub, kni-qe-107 spoke) with 4.18-compatible operator channels (ACM release-2.13, MCE stable-2.8, TALM fbc-4-18, cluster-logging stable-6.1).
rdiscala
force-pushed
the
TELCOV10N-1089-add-4.18-sno-day2-worker
branch
from
e6742fb to
0742246
Compare
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-sno-day2-worker-4.18-cnf-ran-ztp-tests |
|
@rdiscala: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@rdiscala: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Adapts the existing 4.20 sno-day2-worker variant to OpenShift 4.18, using the same infrastructure (kni-qe-106 hub, kni-qe-107 spoke) with 4.18-compatible operator channels (ACM release-2.13, MCE stable-2.8, TALM fbc-4-18, cluster-logging stable-6.1).
Adds a ci-operator configuration to run the SNO day2-worker ZTP CI lane against OpenShift 4.18 for the openshift-kni/eco-ci-cd setup.
What changed in practical terms
Key configuration details
Metadata
Impact