Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3038,6 +3038,82 @@ tests:
test:
- chain: openshift-e2e-test-qe-destructive
workflow: cucushift-installer-rehearse-gcp-ipi-proxy-etcd-encryption
- as: gcp-ipi-px-etcd-enc-rhcos10-tp-fips-amd-f28-compliance
cron: 39 3 4 * *
steps:
cluster_profile: gcp-qe
env:
CATALOG_SOURCE_NAME: compliance-operator
COMPUTE_NODE_REPLICAS: "2"
FEATURE_SET: TechPreviewNoUpgrade
FILTERS_ADDITIONAL: ""
FIPS_ENABLED: "true"
OS_IMAGE_STREAM: rhel-10
TEST_FILTERS: ~HyperShiftMGMT&;~DEPRECATED&;~Disruptive&
TEST_PARALLEL: "3"
TEST_SCENARIOS: Compliance_Operator
TEST_TIMEOUT: "30"
test:
- ref: file-integrity-konflux-catalogsource
- ref: openshift-extended-test
- ref: openshift-e2e-test-qe-report
workflow: cucushift-installer-rehearse-gcp-ipi-proxy-etcd-encryption
- as: gcp-ipi-px-etcd-enc-rhcos10-tp-fips-amd-f28-compliance-dest
cron: 52 1 26 * *
steps:
cluster_profile: gcp-qe
env:
CATALOG_SOURCE_NAME: compliance-operator
COMPUTE_NODE_REPLICAS: "2"
FEATURE_SET: TechPreviewNoUpgrade
FILTERS_ADDITIONAL: ""
FIPS_ENABLED: "true"
OS_IMAGE_STREAM: rhel-10
TEST_FILTERS: ~HyperShiftMGMT&;~StressTest&;~DEPRECATED&;Disruptive&
TEST_PARALLEL: "3"
TEST_SCENARIOS: Compliance_Operator
TEST_TIMEOUT: "55"
test:
- ref: file-integrity-konflux-catalogsource
- ref: openshift-extended-test
- ref: openshift-e2e-test-qe-report
workflow: cucushift-installer-rehearse-gcp-ipi-proxy-etcd-encryption
- as: gcp-ipi-px-etcd-enc-rhcos10-tp-fips-amd-f28-file-integrity
cron: 31 13 30 * *
steps:
cluster_profile: gcp-qe
env:
FEATURE_SET: TechPreviewNoUpgrade
FILTERS_ADDITIONAL: ""
FIPS_ENABLED: "true"
OS_IMAGE_STREAM: rhel-10
TEST_FILTERS: ~HyperShiftMGMT&;~DEPRECATED&
TEST_PARALLEL: "3"
TEST_SCENARIOS: File_Integrity_Operator
TEST_TIMEOUT: "30"
test:
- ref: file-integrity-konflux-catalogsource
- ref: openshift-extended-test
- ref: openshift-e2e-test-qe-report
workflow: cucushift-installer-rehearse-gcp-ipi-proxy-etcd-encryption
- as: gcp-ipi-px-etcd-enc-rhcos10-tp-fips-amd-f28-security-profiles
cron: 12 0 4 * *
steps:
cluster_profile: gcp-qe
env:
CATALOG_SOURCE_NAME: security-profiles-operator
FEATURE_SET: TechPreviewNoUpgrade
FILTERS_ADDITIONAL: ""
FIPS_ENABLED: "true"
OS_IMAGE_STREAM: rhel-10
TEST_FILTERS: ~HyperShiftMGMT&;~DEPRECATED&
TEST_PARALLEL: "3"
TEST_SCENARIOS: Security_Profiles_Operator|Node_Audit_Logging
test:
- ref: file-integrity-konflux-catalogsource
- ref: openshift-extended-test
- ref: openshift-e2e-test-qe-report
workflow: cucushift-installer-rehearse-gcp-ipi-proxy-etcd-encryption
Comment on lines +3041 to +3116
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Keep tests entries alphabetically sorted by as key.

The new gcp-ipi-px-etcd-enc-* jobs are inserted in the middle of the gcp-ipi-proxy-etcd-encryption-* block (between Line 3041 and Line 3117), which breaks required alphabetical ordering. Please move the four gcp-ipi-px-* entries to their correct sorted position (after all gcp-ipi-proxy-* entries).

As per coding guidelines, "Ensure all jobs are ordered alphabetically".

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-4.22__multi-nightly.yaml`
around lines 3041 - 3116, The tests block is out of alphabetical order: the four
entries whose as keys start with "gcp-ipi-px-etcd-enc-rhcos10-tp-fips-amd-f28-"
(e.g., gcp-ipi-px-etcd-enc-rhcos10-tp-fips-amd-f28-compliance, -compliance-dest,
-file-integrity, -security-profiles) must be moved so they appear after the
existing "gcp-ipi-proxy-..." jobs; relocate those four whole job entries and
ensure the surrounding tests list remains alphabetically ordered by the as key
and that each job’s fields (cron, steps, env, test, workflow) are preserved
exactly.

- as: gcp-ipi-proxy-etcd-encryption-rhcos10-tp-mini-perm-arm-f14
cron: 12 5 6,22 * *
steps:
Expand Down
Loading