Skip to content

[release-4.22] OCPBUGS-85827: fix tnf monitor tests#31184

Open
eggfoobar wants to merge 3 commits into
openshift:release-4.22from
eggfoobar:backport-fix-tnf-monitor-tests
Open

[release-4.22] OCPBUGS-85827: fix tnf monitor tests#31184
eggfoobar wants to merge 3 commits into
openshift:release-4.22from
eggfoobar:backport-fix-tnf-monitor-tests

Conversation

@eggfoobar
Copy link
Copy Markdown
Contributor

@eggfoobar eggfoobar commented May 15, 2026

No description provided.

eggfoobar and others added 3 commits May 15, 2026 14:57
@eggfoobar
monitortests: allow etcd CO blips during TNF jobs on two-node upgrades
fc13afb 
Teach legacy CVO monitor tests to treat cluster-etcd-operator condition
reasons shaped as tnf-*_JobRunning as expected on DualReplica and
HighlyAvailableArbiter topologies: Available=False during upgrade, and
Progressing=True while machine-config is progressing.

Add isTNFJobClusterOperatorReason helper and unit tests so we only match
CEO job-running surfaces, not unrelated etcd failures.

Co-authored-by: Cursor Composer <noreply@cursor.com>
Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar
monitortests: broaden dual-replica CVO exceptions for TNF upgrade fol…
bc8a513 
…low-ups

Allow etcd Progressing while MCO runs when CEO reports EtcdMembers_MembersNotStarted
(member still joining during fencing/replacement), in addition to existing tnf-*_JobRunning.

On dual-replica, tolerate openshift-apiserver Available blips for
APIServices_PreconditionNotReady during upgrade, and MCO-time Progressing for
OperatorConfig_NewGeneration (openshift-apiserver) and APIServerDeployment_NewGeneration
(authentication) as operators roll the control plane alongside machine-config.

Co-authored-by: Cursor Composer <noreply@cursor.com>
Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar
monitortests: dual-replica etcd NodeInstaller and samples API flake e…
805b498 
…xceptions

Allow clusteroperator/etcd Progressing=True with reason NodeInstaller while MCO
is progressing on DualReplica (static pod revision rollout overlapping MCO).

During upgrade on DualReplica, tolerate openshift-samples Available=False with
SampleUpsertsPending and Degraded=True with APIServerServiceUnavailableError
when template writes hit transient apiserver errors.

Co-authored-by: Cursor Composer <noreply@cursor.com>
Signed-off-by: ehila <ehila@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 15, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9281d536-185d-4eeb-a181-b01e09efae40

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 15, 2026

@eggfoobar: This pull request references Jira Issue OCPBUGS-85827, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from deads2k and p0lyn0mial May 15, 2026 19:08
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eggfoobar
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 15, 2026

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@eggfoobar
Copy link
Copy Markdown
Contributor Author

eggfoobar commented May 15, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 15, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 15, 2026

@eggfoobar: This pull request references Jira Issue OCPBUGS-85827, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-85058 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-85058 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eggfoobar
Copy link
Copy Markdown
Contributor Author

eggfoobar commented May 15, 2026

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-upgrade

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 15, 2026

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/48049660-5097-11f1-86b2-ed5927860a2e-0

@eggfoobar
Copy link
Copy Markdown
Contributor Author

eggfoobar commented May 16, 2026

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-upgrade

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 16, 2026

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dcb70420-50f4-11f1-912c-9ef96dcf87ca-0

@eggfoobar
Copy link
Copy Markdown
Contributor Author

eggfoobar commented May 16, 2026

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-upgrade

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 16, 2026

@eggfoobar: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b51d2fb0-516d-11f1-843f-8b7daa942a16-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

Assignees

No one assigned

Labels

jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eggfoobar @openshift-ci-robot