OCPNODE-4516: Migrate testcase 67564 from OTP to origin#31161
Open
BhargaviGudi wants to merge 1 commit into
Open
OCPNODE-4516: Migrate testcase 67564 from OTP to origin#31161BhargaviGudi wants to merge 1 commit into
BhargaviGudi wants to merge 1 commit into
Conversation
Contributor
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
Contributor
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
added
the
needs-rebase
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds a disruptive E2E that verifies Node drain blocking E2E + supporting test helpers
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error, 1 warning)
✅ Passed checks (10 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BhargaviGudi The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
BhargaviGudi
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
test/extended/node/node_e2e/node.go (1)
222-234: ⚡ Quick winUse
wait.PollUntilContextTimeoutand referencereplicasinstead of hardcoded6.
wait.Pollis deprecated in favor of the context-aware variantwait.PollUntilContextTimeoutink8s.io/apimachinery. Also,deploy.Status.ReadyReplicas == 6ignores the localreplicasvariable defined at the start of this test, so future changes to the replica count will silently drift.♻️ Suggested refactor
- err = wait.Poll(3*time.Second, 5*time.Minute, func() (bool, error) { - deploy, pollErr := oc.KubeClient().AppsV1().Deployments(namespace).Get(ctx, "hello-openshift", metav1.GetOptions{}) + err = wait.PollUntilContextTimeout(ctx, 3*time.Second, 5*time.Minute, true, func(ctx context.Context) (bool, error) { + deploy, pollErr := oc.KubeClient().AppsV1().Deployments(namespace).Get(ctx, "hello-openshift", metav1.GetOptions{}) if pollErr != nil { e2e.Logf("Error getting deployment: %v", pollErr) return false, nil } - if deploy.Status.ReadyReplicas == 6 { + if deploy.Status.ReadyReplicas == replicas { e2e.Logf("Deployment is ready with %d replicas", deploy.Status.ReadyReplicas) return true, nil } - e2e.Logf("Waiting for deployment, ready replicas: %d/6", deploy.Status.ReadyReplicas) + e2e.Logf("Waiting for deployment, ready replicas: %d/%d", deploy.Status.ReadyReplicas, replicas) return false, nil })🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/extended/node/node_e2e/node.go` around lines 222 - 234, Replace the deprecated wait.Poll call with the context-aware wait.PollUntilContextTimeout variant and use the local replicas variable instead of the hardcoded 6: change the wait invocation to wait.PollUntilContextTimeout(ctx, 3*time.Second, 5*time.Minute, func(...) { ... }) (or the exact k8s signature) and inside the closure compare deploy.Status.ReadyReplicas == replicas; keep the same oc.KubeClient().AppsV1().Deployments(namespace).Get(...) call and existing logging but update messages to reference replicas so the check follows the test's replicas variable.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/extended/node/node_e2e/node.go`:
- Around line 259-262: The pod-count assertion is wrong because
strings.Split(podsInWorker, " ") yields [""] for empty output; update the check
after the oc.AsAdmin().WithoutNamespace().Run(...).Output() call so it verifies
podsInWorker is non-empty or uses strings.Fields(podsInWorker) and asserts
len(...) > 0 (e.g., replace len(strings.Split(podsInWorker, " ")) check with
len(strings.Fields(podsInWorker)) > 0 or
o.Expect(podsInWorker).NotTo(o.BeEmpty())), referencing the podsInWorker
variable and the oc.AsAdmin().WithoutNamespace().Run(...) call that produces it
and keeping the existing o.Expect(err).NotTo(o.HaveOccurred()).
- Around line 165-167: This test assumes dedicated worker nodes; add a topology
guard (skip) before this g.It("[OTP] node's drain...") so it does not run on
SNO, TNF or TNA topologies — follow the pattern used in the existing BeforeEach
MicroShift guard: detect cluster topology (the same helper used elsewhere in the
file) and call Skipf when topology is SingleNode (SNO), TNF, or TNA so
GetSingleWorkerNode won't return the only schedulable host; place the guard at
the start of the test or in the surrounding BeforeEach to ensure the drain logic
(and GetSingleWorkerNode usage) is not exercised on those topologies.
- Around line 264-267: The current check reads .status.conditions[0].status
immediately which can be empty; instead poll until the DisruptionAllowed
condition exists and then assert its status is "False". Replace the single
immediate get that sets pdbStatus with a short retry/poll (e.g.,
wait.PollImmediate or Ginkgo Eventually) that runs
oc.AsAdmin().WithoutNamespace().Run("get").Args("poddisruptionbudget", "my-pdb",
"-n", namespace,
"-o=jsonpath={.status.conditions[?(@.type==\"DisruptionAllowed\")].status}")
until the jsonpath returns a non-empty value, then assert that the returned
value equals "False" (avoid strings.Contains on possibly empty string).
In `@test/extended/node/node_utils.go`:
- Around line 754-767: The WaitClusterOperatorAvailable helper currently can
return false positives when availableCOStatus is empty and uses an excessive
120-minute timeout; update WaitClusterOperatorAvailable to verify the output is
non-empty and that every token equals "True" (or, better, replace the jsonpath
approach by using the typed configv1 ClusterOperator client to iterate all
ClusterOperators and assert each has an Available condition with
Status==configv1.ConditionTrue), and reduce the timeout constant from
120*time.Minute to a shorter cap (e.g., 30–45 minutes) so
wait.PollUntilContextTimeout enforces the tighter limit; adjust the polling
closure (where availableCOStatus, err :=
oc.AsAdmin().WithoutNamespace().Run("get").Args(...).Output() is used) to return
false on empty output or any non-True condition and surface real errors via
waitErr.
---
Nitpick comments:
In `@test/extended/node/node_e2e/node.go`:
- Around line 222-234: Replace the deprecated wait.Poll call with the
context-aware wait.PollUntilContextTimeout variant and use the local replicas
variable instead of the hardcoded 6: change the wait invocation to
wait.PollUntilContextTimeout(ctx, 3*time.Second, 5*time.Minute, func(...) { ...
}) (or the exact k8s signature) and inside the closure compare
deploy.Status.ReadyReplicas == replicas; keep the same
oc.KubeClient().AppsV1().Deployments(namespace).Get(...) call and existing
logging but update messages to reference replicas so the check follows the
test's replicas variable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: edfa1ee0-5c80-4ee0-9bdd-d0a819f8f1bc
📒 Files selected for processing (2)
test/extended/node/node_e2e/node.gotest/extended/node/node_utils.go
BhargaviGudi
force-pushed
the
migrate-67564
branch
from
bbcfd5b to
f6be5a1
Compare
openshift-ci
Bot
removed
the
needs-rebase
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
BhargaviGudi
changed the title
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
Contributor
Author
|
/pipeline required |
Contributor
|
Scheduling required tests: |
BhargaviGudi
force-pushed
the
migrate-67564
branch
from
656bc72 to
b1da642
Compare
openshift-merge-bot
Bot
added
the
ready-for-human-review
Contributor
|
Scheduling required tests: |
BhargaviGudi
changed the title
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
cpmeadors
reviewed
May 12, 2026
cpmeadors
reviewed
May 12, 2026
cpmeadors
reviewed
May 12, 2026
BhargaviGudi
force-pushed
the
migrate-67564
branch
from
b1da642 to
d360edd
Compare
Contributor
|
Scheduling required tests: |
Contributor
Author
|
/retest-required |
BhargaviGudi
force-pushed
the
migrate-67564
branch
2 times, most recently
from
48483a5 to
a2c32b3
Compare
BhargaviGudi
force-pushed
the
migrate-67564
branch
from
a2c32b3 to
e3e96f2
Compare
Contributor
|
Scheduling required tests: |
Contributor
Author
|
/retest-required |
Contributor
|
@BhargaviGudi: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
Author
|
/verified by @BhargaviGudi - the test case was executed on the local cluster and passed successfully. |
openshift-ci-robot
added
the
verified
|
@BhargaviGudi: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
Author
|
/jira refresh |
|
@BhargaviGudi: No Jira issue is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
BhargaviGudi
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@BhargaviGudi: This pull request references OCPNODE-4516 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
Tests need to be documented in test/extended/node/README.md |
openshift-ci
Bot
added
the
needs-rebase
Contributor
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates testcase OCP-67564 from openshift-tests-private to origin.
What this test validates
This test verifies that node drain operations are correctly blocked when a PodDisruptionBudget (PDB) is configured with
minAvailable: 100%and an empty selector (which applies to all pods in thenamespace).
The test:
Implementation details
g.DeferCleanup()for proper Ginkgo-managed resource cleanupTesting
Tested successfully on OCP 4.22 cluster:
Summary by CodeRabbit