-
Notifications
You must be signed in to change notification settings - Fork 4.8k
OCPBUGS-85378: Fix OCP E2E test - Object count when exceed openshift.io/image-tags will ban to create new image references in the project #31155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
YamunadeviShanmugam
wants to merge
7
commits into
openshift:main
Choose a base branch
from
YamunadeviShanmugam:fix-e2e-resource-quota
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+87
−31
Open
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c5ef180
fixed e2e flakiness for resource quota_ban creating new images
YamunadeviShanmugam d3cd554
Updated the test to run in disconnected clusters
YamunadeviShanmugam 4a6d4bf
Fixed requested changes by coderabbit
YamunadeviShanmugam b1ca2e2
updated changes for hypershift specifically
YamunadeviShanmugam 39c6d0b
fixed samples unavailable in hypershift
YamunadeviShanmugam b96e4f7
fixed samples unavailable in hypershift
YamunadeviShanmugam 96733ba
addressed review comments not to use deprecated methods
YamunadeviShanmugam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| package util | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| ) | ||
|
|
||
| const openshiftPayloadImageNamespace = "openshift" | ||
|
|
||
| // SearchLatestImage returns the resolved docker pull spec for imageName:latest in the openshift | ||
| // namespace (payload imagestreams such as cli, tools, must-gather). The cluster serves the | ||
| // architecture-appropriate image; callers must not hardcode digests. | ||
| func SearchLatestImage(oc *CLI, imageName string) (string, error) { | ||
| if imageName == "" { | ||
| return "", fmt.Errorf("imageName is empty") | ||
| } | ||
| ctx := context.Background() | ||
| istag, err := oc.AdminImageClient().ImageV1().ImageStreamTags(openshiftPayloadImageNamespace).Get(ctx, imageName+":latest", metav1.GetOptions{}) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
| ref := istag.Image.DockerImageReference | ||
| if ref == "" { | ||
| return "", fmt.Errorf("empty DockerImageReference for %s/%s:latest", openshiftPayloadImageNamespace, imageName) | ||
| } | ||
| return ref, nil | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.