Skip to content

[release-ocm-2.17] MGMT-20634: Revert mac-identifier and global DNS workarounds as RHEL-91250 and RHEL-72440 resolved#10336

Open
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-ocm-2.17from
openshift-cherrypick-robot:cherry-pick-10318-to-release-ocm-2.17
Open

[release-ocm-2.17] MGMT-20634: Revert mac-identifier and global DNS workarounds as RHEL-91250 and RHEL-72440 resolved#10336
openshift-cherrypick-robot wants to merge 1 commit into
openshift:release-ocm-2.17from
openshift-cherrypick-robot:cherry-pick-10318-to-release-ocm-2.17

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #10318

/assign giladravid16

…91250 and RHEL-72440 resolved As RHEL-72440 and RHEL-91250 are now resolved, we can remove our workarounds for mac-identifir and global DNS. With this fix, if a user sets auto-dns: false and dhcp: true or mac-identifier in their nmstate.yaml, the flow with nmstate.service should correctly apply the networking configuration files.
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 17, 2026

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-20634

Details

In response to this:

This is an automated cherry-pick of #10318

/assign giladravid16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 17, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 793bafc4-21c2-434f-9f2e-bdf39039b487

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 17, 2026
@openshift-ci openshift-ci Bot requested review from carbonin and romfreiman May 17, 2026 09:37
@codecov
Copy link
Copy Markdown

codecov Bot commented May 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.33%. Comparing base (7c94440) to head (2d78d09).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##           release-ocm-2.17   #10336      +/-   ##
====================================================
- Coverage             44.35%   44.33%   -0.02%     
====================================================
  Files                   416      416              
  Lines                 72807    72732      -75     
====================================================
- Hits                  32292    32249      -43     
+ Misses                37585    37567      -18     
+ Partials               2930     2916      -14     
Files with missing lines Coverage Δ
internal/bminventory/inventory.go 72.09% <100.00%> (ø)
internal/ignition/discovery.go 75.00% <100.00%> (ø)
pkg/staticnetworkconfig/backward_compatibility.go 100.00% <100.00%> (+42.04%) ⬆️
pkg/staticnetworkconfig/generator.go 67.73% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gamli75
Copy link
Copy Markdown
Contributor

gamli75 commented May 17, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 17, 2026

@gamli75: This pull request references MGMT-20634 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 17, 2026
@gamli75
Copy link
Copy Markdown
Contributor

gamli75 commented May 17, 2026

/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 7c94440 and 2 for PR HEAD 2d78d09 in total

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 17, 2026

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ai-operator-ztp 2d78d09 link true /test e2e-ai-operator-ztp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants