[release-ocm-2.17] MGMT-20634: Revert mac-identifier and global DNS workarounds as RHEL-91250 and RHEL-72440 resolved#10336
Conversation
…91250 and RHEL-72440 resolved As RHEL-72440 and RHEL-91250 are now resolved, we can remove our workarounds for mac-identifir and global DNS. With this fix, if a user sets auto-dns: false and dhcp: true or mac-identifier in their nmstate.yaml, the flow with nmstate.service should correctly apply the networking configuration files.
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-20634 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-ocm-2.17 #10336 +/- ##
====================================================
- Coverage 44.35% 44.33% -0.02%
====================================================
Files 416 416
Lines 72807 72732 -75
====================================================
- Hits 32292 32249 -43
+ Misses 37585 37567 -18
+ Partials 2930 2916 -14
🚀 New features to boost your workflow:
|
|
/jira refresh |
|
@gamli75: This pull request references MGMT-20634 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gamli75, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #10318
/assign giladravid16