MGMT-24115: [release-ocm-2.17] allow empty image checksum/url in getChecksumAndURL#10324
Conversation
Since OCP 4.10, openshift-install generates Machine ProviderSpecs with customDeploy instead of image data. The image checksum and url fields are empty strings. Commit b19f29b added empty-string validation that treats these as fatal errors, preventing spoke Machine creation for day-2 BMH-backed nodes. The spoke Machine is needed by cluster-machine-approver to auto-approve CSRs. Removes the empty-string checks while keeping all nil/type safety checks.
openshift-ci-robot
added
the
jira/valid-reference
|
@omer-vishlitzky: This pull request references MGMT-24115 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
openshift-ci
Bot
added
the
size/M
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-ocm-2.17 #10324 +/- ##
=================================================
Coverage 44.33% 44.34%
=================================================
Files 416 416
Lines 72807 72803 -4
=================================================
+ Hits 32282 32287 +5
+ Misses 37591 37586 -5
+ Partials 2934 2930 -4
🚀 New features to boost your workflow:
|
|
/retest |
BASIC_CERT was renamed to TEST_CA_CERT on release-ocm-2.17, so the cherry-picked test referenced an undefined symbol. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/override ci/prow/e2e-ai-operator-ztp-capi |
|
/test e2e-ai-operator-ztp |
|
@gamli75: Overrode contexts on behalf of gamli75: ci/prow/e2e-ai-operator-ztp-capi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
/override ci/prow/e2e-ai-operator-ztp-capi |
|
/approve |
|
@gamli75: Overrode contexts on behalf of gamli75: ci/prow/e2e-ai-operator-ztp-capi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gamli75, omer-vishlitzky The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/retest-required |
1 similar comment
|
/retest-required |
|
/override ci/prow/e2e-ai-operator-disconnected-capi ci/prow/e2e-ai-operator-ztp |
|
@gamli75: Overrode contexts on behalf of gamli75: ci/prow/e2e-ai-operator-disconnected-capi, ci/prow/e2e-ai-operator-ztp DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-ai-operator-ztp-capi |
|
@gamli75: Overrode contexts on behalf of gamli75: ci/prow/e2e-ai-operator-ztp-capi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@omer-vishlitzky: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Cherry-pick of #10246 to release-ocm-2.17.
https://redhat.atlassian.net/browse/MGMT-24115
Day-2 node CSR auto-approval fails because no Machine object is created for BMH-backed nodes. Since OCP 4.10, openshift-install generates Machine ProviderSpecs with customDeploy and empty image checksum/url. The empty-string validation rejects these, preventing spoke Machine creation.
Removes the empty-string checks while keeping all nil/type safety checks.