Skip to content

NO-ISSUE: Fix resource leak and inconsistency in manifest download #10322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zaneb wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

NO-ISSUE: Fix resource leak and inconsistency in manifest download #10322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/cluster/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1358,12 +1358,13 @@ func (m *Manager) createClusterDataFiles(ctx context.Context, c *common.Cluster,
if !exists {
continue
}
response, numberOfBytes, err := m.objectHandler.Download(ctx, objectName)
response, numberOfBytes, err := objectHandler.Download(ctx, objectName)
if err != nil {
log.WithError(err).Errorf("failed to download file %s from cluster while building log: %s", path, *c.ID)
continue
}
fileContent, err := io.ReadAll(response)
response.Close()
if err != nil {
log.WithError(err).Errorf("failed to read file data %s (%d) from cluster while building log: %s", path, numberOfBytes, *c.ID)
continue
Expand Down