ART-18353: switch networking-console-plugin pkg_managers from yarn to npm (4.19)#10504
Conversation
|
@joepvd: This pull request references ART-18353 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.z" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Triggered seed-lockfile test build #394 to verify (ASSEMBLY=test, data from this PR branch). |
|
@joepvd: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Switch
pkg_managersfromyarntonpmfor networking-console-plugin on openshift-4.19.Same fix as PR for ART-18521 (openshift-4.18). The upstream source uses
package-lock.json(npm), not
yarn.lock. The hermeto/yarn prefetch handler fails because it cannot determinethe yarn version. This aligns with openshift-4.20 which already uses
pkg_managers: [npm].Failing build: https://art-build-history-art-build-history.apps.artc2023.pc3z.p1.openshiftapps.com/?name=^networking-console-plugin$&group=openshift-4.19&assembly=stream&engine=konflux&outcome=failure
Analysis
The hermeto prefetch step fails with:
The upstream repo has
package-lock.json(npm) across all branches. The 4.20 configalready uses
pkg_managers: [npm]and builds fine.Changes
content.source.pkg_managersfrom[yarn]to[npm]Generated with Claude Code