ART-18521: switch networking-console-plugin pkg_managers from yarn to npm (4.18)#10503
Conversation
|
@joepvd: This pull request references ART-18521 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.z" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Triggered seed-lockfile test build #393 to verify (ASSEMBLY=test, data from this PR branch). |
|
@joepvd: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Switch
pkg_managersfromyarntonpmfor networking-console-plugin on openshift-4.18.The upstream source uses
package-lock.json(npm), notyarn.lock. The hermeto/yarnprefetch handler fails because it cannot determine the yarn version — there is no
packageManagerinpackage.jsonand no.yarnrc.ymlin the repo.This aligns with openshift-4.20 which already uses
pkg_managers: [npm]and buildssuccessfully.
Failing build: https://art-build-history-art-build-history.apps.artc2023.pc3z.p1.openshiftapps.com/?name=^networking-console-plugin$&group=openshift-4.18&assembly=stream&engine=konflux&outcome=failure
Analysis
The hermeto prefetch step fails with:
The upstream repo has
package-lock.json(npm) across all branches (4.18, 4.19, 4.20).The 4.20 ocp-build-data config already uses
pkg_managers: [npm]and builds fine.Changes
content.source.pkg_managersfrom[yarn]to[npm]Generated with Claude Code