HYPBLD-844: Add MCE product mapping for Konflux kubeconfig and CPE labels#2936
Conversation
Mirror ACM onboarding (art-tools openshift-eng#2923, openshift-eng#2910) for product mce: - PRODUCT_NAMESPACE_MAP and PRODUCT_KUBECONFIG_MAP (crt-redhat-acm-tenant) - CPE_PRODUCT_NAME_MAPPING for multicluster_engine rebasing labels Co-authored-by: Cursor <cursoragent@cursor.com>
|
@girish1430: This pull request references HYPBLD-844 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughThis PR adds MCE (multicluster engine) product support by registering it in three product configuration constant maps: the namespace map pointing to ChangesMCE Product Registration
🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @girish1430. Thanks for your PR. I'm waiting for a openshift-eng member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashwindasr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
Summary
Adds
mceproduct mappings for MCE 2.11 ART onboarding (HYPBLD-844), following the ACM changes in:PRODUCT_KUBECONFIG_MAP/PRODUCT_NAMESPACE_MAPforacmCPE_PRODUCT_NAME_MAPPINGforacmartcommon/artcommonlib/constants.pyPRODUCT_NAMESPACE_MAP"mce": "art-acm-tenant"PRODUCT_KUBECONFIG_MAP"mce": "ACM_KONFLUX_SA_KUBECONFIG"MCE 2.11 Konflux builds run in
crt-redhat-acm-tenant(same workspace/credential as ACM).doozer/doozerlib/backend/rebaser.pyCPE_PRODUCT_NAME_MAPPING'mce': 'multicluster_engine'Matches CPE labels used on MCE container images (e.g.
cpe:/a:redhat:multicluster_engine:...).Companion: ocp-build-data #10730 (
product: mceonmce-2.11).Test plan
build-layered-productsformce-2.11no longer raisesValueError: Kubeconfig required for Konflux buildsart-acm-tenantnamespace for productmcemulticluster_engineMade with Cursor