Skip to content

feat: make contact title optional #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anonymoususer72041 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: make contact title optional #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2631961
Allow contacts without a title
anonymoususer72041 May 12, 2026
d8c2fdd
Update contact forms for optional title
anonymoususer72041 May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/contacts/Add.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
<label id="titleLabel" for="title">Title:</label>
</td>
<td class="tdData">
<input type="text" name="title" id="title" class="inputbox" style="width: 150px" />&nbsp;*
<input type="text" name="title" id="title" class="inputbox" style="width: 150px" />
</td>
</tr>

Expand Down
4 changes: 2 additions & 2 deletions modules/contacts/ContactsUI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ private function onAdd()
$departmentsCSV = $this->getTrimmedInput('departmentsCSV', $_POST);

/* Bail out if any of the required fields are empty. */
if (empty($firstName) || empty($lastName) || empty($title))
if (empty($firstName) || empty($lastName))
{
CommonErrors::fatal(COMMONERROR_MISSINGFIELDS, $this, 'Required fields are missing.');
}
Expand Down Expand Up @@ -835,7 +835,7 @@ private function onEdit()
$departmentsCSV = $this->getTrimmedInput('departmentsCSV', $_POST);

/* Bail out if any of the required fields are empty. */
if (empty($firstName) || empty($lastName) || empty($title))
if (empty($firstName) || empty($lastName))
{
CommonErrors::fatal(COMMONERROR_MISSINGFIELDS, $this, 'Required fields are missing.');
}
Expand Down
2 changes: 1 addition & 1 deletion modules/contacts/Edit.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
<label id="titleLabel" for="title">Title:</label>
</td>
<td class="tdData">
<input type="text" name="title" id="title" value="<?php $this->_($this->data['title']); ?>" class="inputbox" style="width: 150px" />&nbsp;*
<input type="text" name="title" id="title" value="<?php $this->_($this->data['title']); ?>" class="inputbox" style="width: 150px" />
</td>
</tr>

Expand Down
2 changes: 0 additions & 2 deletions modules/contacts/validator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ function checkAddForm(form)
errorMessage += checkFirstName();
errorMessage += checkLastName();
errorMessage += checkCompany();
errorMessage += checkTitle();

if (errorMessage != "")
{
Expand All @@ -33,7 +32,6 @@ function checkEditForm(form)
errorMessage += checkFirstName();
errorMessage += checkLastName();
errorMessage += checkCompany();
errorMessage += checkTitle();

if (errorMessage != "")
{
Expand Down
Loading