fix: prefill installer phone country code from site settings#766
Open
anonymoususer72041 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
In this exceptional case, it makes sense to wait to merge this fix until version 0.9.8.0 is released. The Default Phone Country Code is new and not yet included in any installation. Therefore, when upgrading with the introduction of the Default Phone Country Code feature, users will have to explicitly select a Default Phone Country Code and it won't be pre-assigned with +1 and potentially overlooked. Of course, it wouldn't be a problem if this fix were included in version 0.9.8.0 anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the install wizard so the default phone country calling code field is prefilled from the existing
site.default_phone_country_codevalue when available.Previously, the install wizard always rendered the local phone country calling code input as empty, even if a value was already stored in the database. This could cause the existing setting to be overlooked during installer runs.