Skip to content

fix(perf): update df_engine mount path to /home/nonroot in syslog-tcp-otelcol nightly suite#3032

Merged
lquerel merged 1 commit into
open-telemetry:mainfrom
cijothomas:fix/syslog-tcp-otelcol-mount-path
May 19, 2026
Merged

fix(perf): update df_engine mount path to /home/nonroot in syslog-tcp-otelcol nightly suite#3032
lquerel merged 1 commit into
open-telemetry:mainfrom
cijothomas:fix/syslog-tcp-otelcol-mount-path

Conversation

@cijothomas
Copy link
Copy Markdown
Member

The nightly Pipeline Performance Tests run 26069747923 failed in the "Run syslog TCP performance test otelcol log suite" step because the backend (df_engine) container never became ready (readiness check timed out after 10 attempts).

Root cause: PR #2919 switched the df_engine image from musl/alpine to glibc/distroless, changing the in-container home directory from /home/dataflow to /home/nonroot, and updated the volume mount path in all then-existing nightly docker yamls. The syslog-tcp-otelcol-docker.yaml suite (added concurrently in #2962) was missed, so it was still mounting the backend config at /home/dataflow/config.yaml — a path that doesn't exist in the new image — causing the backend container to fail to start.

This one-line change brings it in line with the other nightly suites.

Copilot AI review requested due to automatic review settings May 19, 2026 05:21
@cijothomas cijothomas requested a review from a team as a code owner May 19, 2026 05:21
@github-actions github-actions Bot added the ci-repo Repository maintenance, build, GH workflows, repo cleanup, or other chores label May 19, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/pr-size-label.yml Outdated
Comment thread .github/workflows/pr-size-label.yml Outdated
@cijothomas cijothomas force-pushed the fix/syslog-tcp-otelcol-mount-path branch from 16aa1b5 to 75cc246 Compare May 19, 2026 05:23
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.95%. Comparing base (2688ea1) to head (75cc246).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3032      +/-   ##
==========================================
- Coverage   85.95%   85.95%   -0.01%     
==========================================
  Files         725      725              
  Lines      276289   276289              
==========================================
- Hits       237485   237474      -11     
- Misses      38280    38291      +11     
  Partials      524      524              
Components Coverage Δ
otap-dataflow 87.08% <ø> (-0.01%) ⬇️
query_abstraction 80.61% <ø> (ø)
query_engine 89.57% <ø> (ø)
otel-arrow-go 52.45% <ø> (ø)
quiver 92.25% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lquerel lquerel added this pull request to the merge queue May 19, 2026
Merged via the queue into open-telemetry:main with commit 5bcb1d1 May 19, 2026
84 of 86 checks passed
@cijothomas cijothomas deleted the fix/syslog-tcp-otelcol-mount-path branch May 19, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-repo Repository maintenance, build, GH workflows, repo cleanup, or other chores

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants