Skip to content

Validate quiver otel_* event names at compile time#2977

Open
cijothomas wants to merge 2 commits into
open-telemetry:mainfrom
cijothomas:validate-quiver-event-names
Open

Validate quiver otel_* event names at compile time#2977
cijothomas wants to merge 2 commits into
open-telemetry:mainfrom
cijothomas:validate-quiver-event-names

Conversation

@cijothomas
Copy link
Copy Markdown
Member

Follow-up to #2957, which intentionally skipped the local macro copies in the quiver crate.

Zero runtime cost (compile-time only). All existing quiver call sites already use short stable identifiers (e.g. quiver.wal.rotate), so no call-site updates were required.

@cijothomas cijothomas requested a review from a team as a code owner May 14, 2026 18:14
@github-actions github-actions Bot added the rust Pull requests that update Rust code label May 14, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.92%. Comparing base (f562f90) to head (1a534e7).

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2977      +/-   ##
==========================================
- Coverage   85.93%   85.92%   -0.02%     
==========================================
  Files         725      725              
  Lines      275782   275792      +10     
==========================================
- Hits       236996   236975      -21     
- Misses      38262    38293      +31     
  Partials      524      524              
Components Coverage Δ
otap-dataflow 87.05% <0.00%> (-0.02%) ⬇️
query_abstraction 80.61% <ø> (ø)
query_engine 89.57% <ø> (ø)
otel-arrow-go 52.45% <ø> (ø)
quiver 92.18% <0.00%> (-0.08%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AaronRM
Copy link
Copy Markdown
Contributor

AaronRM commented May 14, 2026

LGTM. Thanks @cijothomas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants