Skip to content

fix(deps): upgrade urllib3 to 2.7.0 to address CVE-2026-44432#2960

Draft
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-urllib3-decompression-bomb-issue
Draft

fix(deps): upgrade urllib3 to 2.7.0 to address CVE-2026-44432#2960
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-urllib3-decompression-bomb-issue

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 13, 2026

Bumps urllib3 from 2.6.3 → 2.7.0 in the pipeline perf test orchestrator to address GHSA-mf9v-mfxr-j63j / CVE-2026-44432: decompression-bomb safeguards bypassed in the streaming API (HTTPResponse.read(amt=N) with Brotli, and HTTPResponse.drain_conn() after partial decompression).

Change Summary

  • requirements.txt: added explicit urllib3>=2.7.0 security pin (urllib3 is otherwise an unpinned transitive dep of requests, docker, and kubernetes)
  • requirements.lock.txt: regenerated via pip-compile --generate-hashes to lock urllib3 at 2.7.0

Reachability: not reachable (high confidence). The orchestrator uses the high-level requests API and never calls HTTPResponse.drain_conn() or the raw streaming HTTPResponse.read(amt=N) directly. This update satisfies vulnerability scanners as a defense-in-depth measure.

How are these changes tested?

No functional changes; dependency version bump only. Verified the lock file resolves urllib3==2.7.0.

Are there any user-facing changes?

No.

Original prompt

This section details the Dependabot vulnerability alert you should resolve

<alert_title>urllib3: Decompression-bomb safeguards bypassed in parts of the streaming API</alert_title>
<alert_description>### Impact

urllib3's streaming API is designed for the efficient handling of large HTTP responses by reading the content in chunks, rather than loading the entire response body into memory at once.

urllib3 can perform decompression based on the HTTP Content-Encoding header (e.g., gzip, deflate, br, or zstd). When using the streaming API since version 2.6.0, the library decompresses only the necessary bytes, enabling partial content consumption.

However, urllib3 before version 2.7.0 could still decompress the whole response instead of the requested portion in two cases:

  1. During the second HTTPResponse.read(amt=N) call when the response was decompressed using the official Brotli library.
  2. When HTTPResponse.drain_conn() was called after the response had been read and decompressed partially (compression algorithm did not matter here).

These issues could cause urllib3 to fully decode a small amount of highly compressed data in a single operation. This could result in excessive resource consumption (high CPU usage and massive memory allocation for the decompressed data; CWE-409) on the client side.

Affected usages

Applications and libraries using urllib3 versions earlier than 2.7.0 may be affected when streaming compressed responses from untrusted sources in either of these cases, unless decompression is explicitly disabled:

  1. A response encoded with br is read incrementally with at least two HTTPResponse.read(amt=N) or HTTPResponse.stream(amt=N) calls while using the official Brotli library.
  2. HTTPResponse.drain_conn() is called after response decompression has already started.

Remediation

Upgrade to at least urllib3 version 2.7.0 in which the library:

  1. Is more efficient for reads with Brotli.
  2. Always skips decompression for HTTPResponse.drain_conn().

If upgrading is not immediately possible, the following workarounds may reduce exposure in specific cases:

  1. For the Brotli-specific issue only, switch from brotli to brotlicffi until you can upgrade urllib3; the official Brotli package is affected because of [Python] output_buffer_limit is not fully respected google/brotli#1396.
  2. If your code explicitly calls HTTPResponse.drain_conn(), call HTTPResponse.close() instead when connection reuse is not important.

Credits

The Brotli-specific issue was reported by @kimkou2024.
HTTPResponse.drain_conn() inefficiency was reported by @Cycloctane.</alert_description>

high
GHSA-mf9v-mfxr-j63j, CVE-2026-44432
urllib3
pip
<vulnerable_versions>= 2.6.3</vulnerable_versions>
<patched_version>2.7.0</patched_version>
<manifest_path>tools/pipeline_perf_test/orchestrator/requirements.txt</manifest_path>

https://github.com/urllib3/urllib3/security/advisories/GHSA-mf9v-mfxr-j63j https://github.com/advisories/GHSA-mf9v-mfxr-j63j

<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explain...

Copilot AI changed the title [WIP] Fix urllib3 decompression-bomb safeguards bypassed in streaming API fix(deps): upgrade urllib3 to 2.7.0 to address CVE-2026-44432 May 13, 2026
Copilot finished work on behalf of reyang May 13, 2026 05:00
Copilot AI requested a review from reyang May 13, 2026 05:00
--hash=sha256:f12b1a9e332c01e09510586f8ca9b108fd631fd656af82e452d7315ef6df5f9f \
--hash=sha256:f4753e73e34c8d83221ba58f232433fca2748be8b18dbca02d242ed153945043 \
--hash=sha256:f8d68083e49e16b84734eb1a4dcae4259a75c90fb6e2251ab9a00b61120c06ab
# via -r tools/pipeline_perf_test/orchestrator/requirements.txt
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why making this change? Seems irrelevant to what the PR title suggested.

Also, is this a duplicate of #2961?

@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.03%. Comparing base (b645a26) to head (db44751).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2960   +/-   ##
=======================================
  Coverage   86.03%   86.03%           
=======================================
  Files         720      720           
  Lines      273264   273264           
=======================================
+ Hits       235095   235098    +3     
+ Misses      37645    37642    -3     
  Partials      524      524           
Components Coverage Δ
otap-dataflow 87.19% <ø> (+<0.01%) ⬆️
query_abstraction 80.61% <ø> (ø)
query_engine 89.57% <ø> (ø)
otel-arrow-go 52.45% <ø> (ø)
quiver 92.25% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants