feat: Add in generation of event names#2132
Draft
thompson-tomo wants to merge 1 commit into
Draft
Conversation
Contributor
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
I think this looks good, @thompson-tomo. Thanks for opening the PR.
| file_name: "incubating/{{ctx.root_namespace | snake_case}}/metrics.rb" | ||
| params: | ||
| incubating: true | ||
| - pattern: events.j2 |
Contributor
There was a problem hiding this comment.
Are all events incubating at this time? Do we need to add any to the stable group?
Contributor
Author
There was a problem hiding this comment.
Yes I was going to add stable but first want to resolve/confirm namespacing situation.
| incubating: true | ||
| - pattern: events.j2 | ||
| application_mode: each | ||
| filter: '.groups | map(select(.type == "event")) | group_by(.name | split(".") | .[0]) | map({id: .[0].id | split(".") | .[1], groups: .})' |
Contributor
There was a problem hiding this comment.
I'm surprised weaver doesn't have a semconv_grouped_events filter. I checked the same spot where semconv_grouped_metrics is defined and didn't see anything. This seems to capture the events well.
Contributor
Author
There was a problem hiding this comment.
It is in the process of being added as it was in the docs but didnt work as wasn't implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.