Skip to content

profiles: improve Link message encoding documentation #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhalliday wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

profiles: improve Link message encoding documentation #792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion opentelemetry/proto/profiles/v1development/profiles.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,12 @@ message ProfilesDictionary {

// Links referenced by samples via Sample.link_index.
//
// link_table[0] must always be zero value (Link{}) and present.
// link_table[0] must always be zero value and present.
// Note that whilst Link{trace_id=array[0], span_id=array[0]} and
// Link{trace_id=array[16], span_id=array[8]} filled with zero-value bytes
// are both appropriate zero/invalid values per the trace.proto:Span definition,
// the latter SHOULD be used for link_table[0] for better compatibility with codecs
// strictly expecting 16/8 byte array lengths.
repeated Link link_table = 4;

// A common table for strings referenced by various messages.
Expand Down
Loading