feat(target-allocator): add allowInsecureAuthSecrets option#5088
Open
tillwulfram wants to merge 1 commit into
Open
feat(target-allocator): add allowInsecureAuthSecrets option#5088tillwulfram wants to merge 1 commit into
tillwulfram wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Currently the TA can only serve discovered auth data, eg. Kubernetes Secrets from a ServiceMonitor with basicauth, over mtls. This great feature would overcomplicate setups for teams who have existing service mesh which already handles the mtls auth between the services or high maintenance for teams who can't use the operator / crds and also for dev setups.
Its configurable bool via config file, CLI flag (
--allow-insecure-auth-secrets), or environment variable (ALLOW_INSECURE_AUTH_SECRETS) - allowing the most flexibility so the operator crds can cover this setting and also the standalone helm chart from the targetAllocator.-> When enabled, a "warn" log will be written at startup that secret are exposed via plaintext.
Defaults to
falseto maintain backwards compatibility.A next feature could be that also https can be configured so no "heavy" mtls is needed, but at least the transport is secured.
Testing:
Expanded the tests for the new feature in the config, flags and the server files.
All tests, precommits and lints were successful.
Documentation:
Added the new config parameter to the targetAllocator and a short description how it can be used, for which environments it should be used and which problem it can solve.