Skip to content

Revert "fix(ci): pin to Node.js v22.22.1 to avoid bug in v22.22.2 (#6550)" #6719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
trentm wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −9
Draft

Revert "fix(ci): pin to Node.js v22.22.1 to avoid bug in v22.22.2 (#6550)" #6719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
fail-fast: false
matrix:
node_version:
- "22.22.1" # pin to avoid bug in 22.22.2
- "22"
runs-on: oracle-bare-metal-64cpu-1024gb-x86-64-ubuntu-24
container:
image: ubuntu:24.04@sha256:c4a8d5503dfb2a3eb8ab5f807da5bc69a85730fb49b5cfca2330194ebcc41c7b
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create-or-update-release-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
with:
cache: 'npm'
cache-dependency-path: package-lock.json
node-version: "22.22.1" # pin to avoid bug in 22.22.2
node-version: 22
- run: npm install -g npm@latest

- run: npm ci --ignore-scripts
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- "18"
- "20.6.0"
- "20"
- "22.22.1" # pin to avoid bug in 22.22.2
- "22"
- "24"
- "25"
- "26"
Expand All @@ -45,7 +45,7 @@ jobs:
- run: npm install -g npm@latest
if: ${{
matrix.node_version == '20' ||
matrix.node_version == '22.22.1' ||
matrix.node_version == '22' ||
matrix.node_version == '24' ||
matrix.node_version == '25' ||
matrix.node_version == '26'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/sbom.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
with:
node-version: "22.22.1" # pin to avoid bug in 22.22.2
node-version: 22

- run: npm install -g npm@latest

Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/unit-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,10 @@ jobs:
matrix.node_version == '18' ||
matrix.node_version == '20.6.0'
}}
# Workaround: skip this install of npm@latest for Node.js v22 to
# workaround https://github.com/nodejs/node/issues/62425
# Npm@latest isn't typically *required*.
- run: npm install -g npm@latest
if: ${{
matrix.node_version == '20' ||
matrix.node_version == '22' ||
matrix.node_version == '24' ||
matrix.node_version == '25' ||
matrix.node_version == '26'
Expand Down Expand Up @@ -80,7 +78,7 @@ jobs:
cache: 'npm'
cache-dependency-path: |
package-lock.json
node-version: "22.22.1" # pin to avoid bug in 22.22.2
node-version: '22'

- run: npm install -g npm@latest

Expand Down
Loading