chore: Add size-limit check on Pull Requests#6706
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6706 +/- ##
==========================================
- Coverage 95.74% 94.83% -0.92%
==========================================
Files 375 376 +1
Lines 12823 12711 -112
Branches 3056 2888 -168
==========================================
- Hits 12277 12054 -223
- Misses 546 657 +111 🚀 New features to boost your workflow:
|
|
nice, almost there :) logs: |
|
or is the failure reason the one you mentioned in the PR description? 🤔 |
Yes exactly. Because it is running against Tbh, it's quite a tough 🐥 🥚 problem for the library to solve. |
Which problem is this PR solving?
Step 1 of #6639
This introduces
.size-limit, a way to detect if the bundle size is increasing or not.gzipis enabled, as everywhere where bundle size mattersgzipis used - so it is more visible how it is really affecting a real-world scenario.This GitHub action runs on every PR and on
main. The action itself is then checking against the PR base branch and checks if something increased or decreased.In this PR it would fail as it seems it needs to have
size-limitinstalled onmain, as it checks in the same PR against the PRs base branchI didn't include any
limitin the.size-limit.jsonas for now it should basically just give some information about the size itself.Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested manually. As explained above, it seems that in this PR it fails on the second check of the compare step. The first size check (against this PR) shows the actual stats, and fails on the
mainstep. Output:[ { "name": "@opentelemetry/api", "size": 3416 }, { "name": "@opentelemetry/api (full)", "size": 4669 }, { "name": "@opentelemetry/core", "size": 279 }, { "name": "@opentelemetry/core (full)", "size": 7839 }, { "name": "@opentelemetry/semantic-conventions", "size": 67 }, { "name": "@opentelemetry/semantic-conventions (full)", "size": 12642 } ]Checklist:
(Not sure if one of the following can be applied for this PR)