refactor(sdk-trace-base, sdk-node): add TracerProvider class and use BasicTracerProvider in Node SDK

experimental/CHANGELOG.md

@@ -46,6 +46,7 @@ For notes on migrating to 2.x / 0.200.x see [the upgrade guide](doc/upgrade-to-2
 
 * test(otlp-transformer): add metrics transform benchmark [#6628](https://github.com/open-telemetry/opentelemetry-js/pull/6628) @pichlermarc
 * refactor(opentelemetry-exporter-prometheus): do not call enforcePrometheusNamingConvention() multiple times per metric [#6636](https://github.com/open-telemetry/opentelemetry-js/pull/6636) @cjihrig
+* refactor(sdk-node): replace usage of `NodeTracerProvider` for `BasicTracerProvider` in SDK start [#6640](https://github.com/open-telemetry/opentelemetry-js/pull/6640) @david-luna
 
 ## 0.215.0
 

experimental/packages/opentelemetry-instrumentation-grpc/test/grpc-protobuf-ts.test.ts

@@ -13,9 +13,9 @@ import * as grpc from '@grpc/grpc-js';
 import { GrpcTesterClient } from './proto/ts/fixtures/grpc-test.client';
 import {
   InMemorySpanExporter,
-  NodeTracerProvider,
+  BasicTracerProvider,
   SimpleSpanProcessor,
-} from '@opentelemetry/sdk-trace-node';
+} from '@opentelemetry/sdk-trace-base';
 import * as protoLoader from '@grpc/proto-loader';
 import * as path from 'path';
 import * as assert from 'assert';
@@ -138,7 +138,7 @@ describe('#grpc-protobuf', () => {
   let client: GrpcTesterClient;
   let server: grpc.Server;
   let contextManager: ContextManager;
-  const provider = new NodeTracerProvider({
+  const provider = new BasicTracerProvider({
     spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
   });
 

experimental/packages/opentelemetry-instrumentation-grpc/test/helper.ts

@@ -6,11 +6,11 @@
 import type { Attributes } from '@opentelemetry/api';
 import { context, propagation, SpanKind, trace } from '@opentelemetry/api';
 import { W3CTraceContextPropagator } from '@opentelemetry/core';
-import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node';
 import { AsyncHooksContextManager } from '@opentelemetry/context-async-hooks';
 import type { ContextManager } from '@opentelemetry/api';
 import type { ReadableSpan } from '@opentelemetry/sdk-trace-base';
 import {
+  BasicTracerProvider,
   InMemorySpanExporter,
   SimpleSpanProcessor,
 } from '@opentelemetry/sdk-trace-base';
@@ -574,7 +574,7 @@ export const runTests = (
 
     const ClientServerValidationTest = (
       method: (typeof methodList)[0],
-      provider: NodeTracerProvider,
+      provider: BasicTracerProvider,
       checkSpans = true,
       attributesValidation?: {
         serverAttributes?: Attributes;
@@ -618,7 +618,7 @@ export const runTests = (
 
     const ErrorValidationTest = (
       method: (typeof methodList)[0],
-      provider: NodeTracerProvider,
+      provider: BasicTracerProvider,
       checkSpans = true,
       attributesValidation?: {
         serverAttributes?: Attributes;
@@ -674,7 +674,7 @@ export const runTests = (
 
     const runTestWithAttributeValidation = (
       method: (typeof methodList)[0],
-      provider: NodeTracerProvider,
+      provider: BasicTracerProvider,
       checkSpans = true,
       attributesValidation: {
         serverAttributes?: Attributes;
@@ -692,7 +692,7 @@ export const runTests = (
 
     const runTest = (
       method: (typeof methodList)[0],
-      provider: NodeTracerProvider,
+      provider: BasicTracerProvider,
       checkSpans = true
     ) => {
       ClientServerValidationTest(method, provider, checkSpans);
@@ -708,7 +708,7 @@ export const runTests = (
       method: (typeof methodList)[0],
       key: string,
       errorCode: number,
-      provider: NodeTracerProvider
+      provider: BasicTracerProvider
     ) => {
       it(`should raise an error for client/server rootSpans: method=${method.methodName}, status=${key}`, async () => {
         const expectEmpty = memoryExporter.getFinishedSpans();
@@ -819,7 +819,7 @@ export const runTests = (
     };
 
     describe('enable()', () => {
-      const provider = new NodeTracerProvider({
+      const provider = new BasicTracerProvider({
         spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
       });
       beforeEach(() => {
@@ -864,7 +864,7 @@ export const runTests = (
     });
 
     describe('disable()', () => {
-      const provider = new NodeTracerProvider({
+      const provider = new BasicTracerProvider({
         spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
       });
       beforeEach(() => {
@@ -896,7 +896,7 @@ export const runTests = (
     });
 
     describe('Test filtering requests using metadata', () => {
-      const provider = new NodeTracerProvider({
+      const provider = new BasicTracerProvider({
         spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
       });
       beforeEach(() => {
@@ -926,7 +926,7 @@ export const runTests = (
     });
 
     describe('Test filtering requests using options', () => {
-      const provider = new NodeTracerProvider({
+      const provider = new BasicTracerProvider({
         spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
       });
       const checkSpans: { [key: string]: boolean } = {
@@ -1004,7 +1004,7 @@ export const runTests = (
     });
 
     describe('Test capturing metadata', () => {
-      const provider = new NodeTracerProvider({
+      const provider = new BasicTracerProvider({
         spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
       });
 

experimental/packages/opentelemetry-instrumentation-http/test/functionals/http-enable.test.ts

@@ -13,8 +13,8 @@ import {
   DiagConsoleLogger,
   INVALID_SPAN_CONTEXT,
 } from '@opentelemetry/api';
-import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node';
 import {
+  BasicTracerProvider,
   InMemorySpanExporter,
   SimpleSpanProcessor,
 } from '@opentelemetry/sdk-trace-base';
@@ -90,7 +90,7 @@ const hostname = 'localhost';
 const pathname = '/test';
 const serverName = 'my.server.name';
 const memoryExporter = new InMemorySpanExporter();
-const provider = new NodeTracerProvider({
+const provider = new BasicTracerProvider({
   spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
 });
 instrumentation.setTracerProvider(provider);

experimental/packages/opentelemetry-instrumentation-http/test/functionals/http-metrics.test.ts

@@ -8,7 +8,7 @@ import {
   InMemoryMetricExporter,
   MeterProvider,
 } from '@opentelemetry/sdk-metrics';
-import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node';
+import { BasicTracerProvider } from '@opentelemetry/sdk-trace-base';
 import {
   ATTR_ERROR_TYPE,
   ATTR_HTTP_REQUEST_METHOD,
@@ -50,7 +50,7 @@ const serverPort = 22346;
 const protocol = 'http';
 const hostname = 'localhost';
 const pathname = '/test';
-const tracerProvider = new NodeTracerProvider();
+const tracerProvider = new BasicTracerProvider();
 const metricsMemoryExporter = new InMemoryMetricExporter(
   AggregationTemporality.DELTA
 );

experimental/packages/opentelemetry-instrumentation-http/test/functionals/http-package.test.ts

@@ -6,8 +6,8 @@
 import type { Span } from '@opentelemetry/api';
 import { context, SpanKind, propagation } from '@opentelemetry/api';
 import { AsyncHooksContextManager } from '@opentelemetry/context-async-hooks';
-import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node';
 import {
+  BasicTracerProvider,
   InMemorySpanExporter,
   SimpleSpanProcessor,
 } from '@opentelemetry/sdk-trace-base';
@@ -41,7 +41,7 @@ describe('Packages', () => {
     context.disable();
   });
   describe('get', () => {
-    const provider = new NodeTracerProvider({
+    const provider = new BasicTracerProvider({
       spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
     });
     instrumentation.setTracerProvider(provider);

experimental/packages/opentelemetry-instrumentation-http/test/functionals/http-sampler.test.ts

@@ -11,9 +11,9 @@ import type {
   SpanKind,
 } from '@opentelemetry/api';
 import { context } from '@opentelemetry/api';
-import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node';
 import type { Sampler, SamplingResult } from '@opentelemetry/sdk-trace-base';
 import {
+  BasicTracerProvider,
   InMemorySpanExporter,
   SamplingDecision,
   SimpleSpanProcessor,
@@ -56,7 +56,7 @@ import * as http from 'http';
 import { AsyncHooksContextManager } from '@opentelemetry/context-async-hooks';
 
 const memoryExporter = new InMemorySpanExporter();
-const provider = new NodeTracerProvider({
+const provider = new BasicTracerProvider({
   sampler,
   spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
 });

experimental/packages/opentelemetry-instrumentation-http/test/functionals/https-package.test.ts

@@ -6,8 +6,8 @@
 import type { Span } from '@opentelemetry/api';
 import { context, SpanKind, propagation } from '@opentelemetry/api';
 import { AsyncHooksContextManager } from '@opentelemetry/context-async-hooks';
-import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node';
 import {
+  BasicTracerProvider,
   InMemorySpanExporter,
   SimpleSpanProcessor,
 } from '@opentelemetry/sdk-trace-base';
@@ -41,7 +41,7 @@ describe('Packages', () => {
     context.disable();
   });
   describe('get', () => {
-    const provider = new NodeTracerProvider({
+    const provider = new BasicTracerProvider({
       spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
     });
     instrumentation.setTracerProvider(provider);

experimental/packages/opentelemetry-instrumentation-http/test/integrations/http-enable.test.ts

@@ -17,8 +17,8 @@ import { urlToHttpOptions } from 'url';
 import { HttpInstrumentation } from '../../src/http';
 import { assertSpan } from '../utils/assertSpan';
 import * as utils from '../utils/utils';
-import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node';
 import {
+  BasicTracerProvider,
   InMemorySpanExporter,
   SimpleSpanProcessor,
 } from '@opentelemetry/sdk-trace-base';
@@ -119,7 +119,7 @@ describe('HttpInstrumentation Integration tests', () => {
       });
     });
 
-    const provider = new NodeTracerProvider({
+    const provider = new BasicTracerProvider({
       spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
     });
     instrumentation.setTracerProvider(provider);

experimental/packages/opentelemetry-instrumentation-http/test/integrations/https-enable.test.ts

@@ -19,8 +19,8 @@ import type { Socket } from 'net';
 import { assertSpan } from '../utils/assertSpan';
 import { urlToHttpOptions } from 'url';
 import * as utils from '../utils/utils';
-import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node';
 import {
+  BasicTracerProvider,
   InMemorySpanExporter,
   SimpleSpanProcessor,
 } from '@opentelemetry/sdk-trace-base';
@@ -119,7 +119,7 @@ describe('HttpsInstrumentation Integration tests', () => {
         done();
       });
     });
-    const provider = new NodeTracerProvider({
+    const provider = new BasicTracerProvider({
       spanProcessors: [new SimpleSpanProcessor(memoryExporter)],
     });
     instrumentation.setTracerProvider(provider);

experimental/packages/opentelemetry-sdk-node/src/index.ts

@@ -14,7 +14,6 @@ export * as contextBase from '@opentelemetry/api';
 export * as core from '@opentelemetry/core';
 export * as logs from '@opentelemetry/sdk-logs';
 export * as metrics from '@opentelemetry/sdk-metrics';
-export * as node from '@opentelemetry/sdk-trace-node';
 export * as resources from '@opentelemetry/resources';
 export * as tracing from '@opentelemetry/sdk-trace-base';
 /* eslint-enable no-restricted-syntax */

experimental/packages/opentelemetry-sdk-node/src/sdk.ts

@@ -39,10 +39,14 @@ import {
   ConsoleMetricExporter,
   PeriodicExportingMetricReader,
 } from '@opentelemetry/sdk-metrics';
-import type { SpanProcessor } from '@opentelemetry/sdk-trace-base';
-import { BatchSpanProcessor } from '@opentelemetry/sdk-trace-base';
-import type { NodeTracerConfig } from '@opentelemetry/sdk-trace-node';
-import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node';
+import type {
+  SpanProcessor,
+  TracerConfig,
+} from '@opentelemetry/sdk-trace-base';
+import {
+  BasicTracerProvider,
+  BatchSpanProcessor,
+} from '@opentelemetry/sdk-trace-base';
 import { ATTR_SERVICE_NAME } from '@opentelemetry/semantic-conventions';
 import type { NodeSDKConfiguration } from './types';
 import {
@@ -64,7 +68,7 @@ import {
 } from './utils';
 
 type TracerProviderConfig = {
-  tracerConfig: NodeTracerConfig;
+  tracerConfig: TracerConfig;
   spanProcessors: SpanProcessor[];
 };
 
@@ -160,7 +164,7 @@ export class NodeSDK {
 
   private _autoDetectResources: boolean;
 
-  private _tracerProvider?: NodeTracerProvider;
+  private _tracerProvider?: BasicTracerProvider;
   private _loggerProvider?: LoggerProvider;
   private _meterProvider?: MeterProvider;
   private _serviceName?: string;
@@ -207,7 +211,7 @@ export class NodeSDK {
       configuration.spanProcessor ||
       configuration.spanProcessors
     ) {
-      const tracerProviderConfig: NodeTracerConfig = {};
+      const tracerProviderConfig: TracerConfig = {};
 
       if (configuration.sampler) {
         tracerProviderConfig.sampler = configuration.sampler;
@@ -346,7 +350,7 @@ export class NodeSDK {
 
     // Only register if there is a span processor
     if (spanProcessors.length > 0) {
-      this._tracerProvider = new NodeTracerProvider({
+      this._tracerProvider = new BasicTracerProvider({
         ...this._configuration,
         resource: this._resource,
         meterProvider: sdkMetricsEnabled ? this._meterProvider : undefined,